From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joshua Henderson <joshua.henderson@microchip.com>,
linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org,
Purna Chandra Mandal <purna.mandal@microchip.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral
Date: Tue, 2 Feb 2016 14:11:39 +0300 [thread overview]
Message-ID: <56B08EEB.3050808@cogentembedded.com> (raw)
In-Reply-To: <1454366701-10847-1-git-send-email-joshua.henderson@microchip.com>
Hello.
On 2/2/2016 1:44 AM, Joshua Henderson wrote:
> From: Purna Chandra Mandal <purna.mandal@microchip.com>
>
> Document the devicetree bindings for the SPI peripheral found
> on Microchip PIC32 class devices.
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> ---
> .../bindings/spi/microchip,spi-pic32.txt | 44 ++++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
> new file mode 100644
> index 0000000..a555618
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
> @@ -0,0 +1,44 @@
> +* Microchip PIC32 SPI device
> +
> +Required properties:
> +- compatible: Should be "microchip,pic32mzda-spi".
> +- reg: Address and length of the register set for the device
> +- interrupts: Should contain all three spi interrupts in sequence
> + of <fault-irq>, <receive-irq>, <transmit-irq>.
> +- interrupt-names: Should be "fault","rx","tx" in order.
Please insert spaces after commas.
> +- clocks: phandles of baud generation clocks. Maximum two possible clocks
Baud in the SPI context?
> + can be provided (&PBCLK2, &REFCLKO1).
Please align.
> + See: Documentation/devicetree/bindings/clock/clock-bindings.txt
> +- clock-names: Should be "mck0","mck1".
Please insert space after comma.
[...]
> +Example:
> +
> + spi1:spi@0x1f821000 {
Please insert spaces after colon.
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-02 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 22:44 [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral Joshua Henderson
2016-02-01 22:44 ` [PATCH 2/2] spi: spi-pic32: Add PIC32 SPI master driver Joshua Henderson
2016-02-02 12:13 ` Mark Brown
2016-02-05 11:57 ` Purna Chandra Mandal
2016-02-02 11:11 ` Sergei Shtylyov [this message]
2016-02-05 5:08 ` [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI peripheral Purna Chandra Mandal
2016-02-05 13:32 ` Sergei Shtylyov
2016-02-08 5:06 ` Purna Chandra Mandal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B08EEB.3050808@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=purna.mandal@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).