From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756553AbcBBSGr (ORCPT ); Tue, 2 Feb 2016 13:06:47 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:40553 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085AbcBBSGp (ORCPT ); Tue, 2 Feb 2016 13:06:45 -0500 Subject: Re: [PATCH 08/11] clk: sunxi: improve error reporting for the mux clock To: Maxime Ripard References: <1454348370-3816-1-git-send-email-andre.przywara@arm.com> <1454348370-3816-9-git-send-email-andre.przywara@arm.com> <20160202180227.GC4652@lukather> Cc: Chen-Yu Tsai , linux-sunxi@googlegroups.com, Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Emilio_L=c3=b3pez?= , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org From: Andre Przywara Organization: ARM Ltd. Message-ID: <56B0EFFD.8070900@arm.com> Date: Tue, 2 Feb 2016 18:05:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160202180227.GC4652@lukather> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Salut, On 02/02/16 18:02, Maxime Ripard wrote: > On Mon, Feb 01, 2016 at 05:39:27PM +0000, Andre Przywara wrote: >> clk_register_mux returns a pointer wrapped error value in case of >> failure, so a simple NULL check is not sufficient to catch errors. >> Fix that and elaborate on the failure reason on the way. The whole >> function does not return any error value, so silently failing may >> leave users scratching their heads because the kernel does not >> provide any clues on what's wrong. >> >> Signed-off-by: Andre Przywara > > Applied, thanks. > > Any chance you do that for the other functions? :) Sure, that was actually a test balloon ;-) Cheers, Andre