From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757701AbcBDFRi (ORCPT ); Thu, 4 Feb 2016 00:17:38 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:41388 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754279AbcBDFRf (ORCPT ); Thu, 4 Feb 2016 00:17:35 -0500 Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support To: Fu Wei , Timur Tabi References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> <56B24AB5.3070001@codeaurora.org> Cc: Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun Guo , Jon Masters , Arnd Bergmann , Leo Duran , Sudeep Holla From: Guenter Roeck Message-ID: <56B2DEE4.7060901@roeck-us.net> Date: Wed, 3 Feb 2016 21:17:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2016 03:00 PM, Fu Wei wrote: > On 4 February 2016 at 02:45, Timur Tabi wrote: >> Fu Wei wrote: >>> >>> As you know I have made the pre-timeout support patch, If people like >>> it, i am happy to go on upstream it separately. >>> >>> If we want to use pre-timeout here, user only can use get_pretimeout >>> and disable panic by setting pretimeout to 0 >>> but user can not really set pretimeout, because "pre-timeout == >>> timeout / 2 (always)". >>> if user want to change pretimeout, he/she has to set_time instead. >> >> >> Ok, I think patches 4 and 5 should be combined, and I think the Kconfig >> entry should be removed and just use panic_enabled. Agreed. > > NP, will update this patchset like that , thanks :-) > Also, if panic is enabled, the timeout needs to be adjusted accordingly (to only panic after the entire timeout period has expired, not after half of it). We can not panic the system after timeout / 2. I am not too happy with the parameter name (panic_enabled). How about "action", to match machzwd ? Thanks, Guenter