From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965636AbcBDOS4 (ORCPT ); Thu, 4 Feb 2016 09:18:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756698AbcBDOSy (ORCPT ); Thu, 4 Feb 2016 09:18:54 -0500 Subject: Re: [mpt3sas driver 03/10] mpt3sas: Fix static analyzer(coverity) tool identified defects To: Suganath prabu Subaramani , JBottomley@Parallels.com, jejb@kernel.org, hch@infradead.org References: <1453963027-19770-1-git-send-email-suganath-prabu.subramani@avagotech.com> <1453963027-19770-4-git-send-email-suganath-prabu.subramani@avagotech.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Sathya.Prakash@avagotech.com, kashyap.desai@avagotech.com, krishnaraddi.mankani@avagotech.com, linux-kernel@vger.kernel.org, chaitra.basappa@avagotech.com, sreekanth.reddy@avagotech.com From: Tomas Henzl Message-ID: <56B35DCB.3000408@redhat.com> Date: Thu, 4 Feb 2016 15:18:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1453963027-19770-4-git-send-email-suganath-prabu.subramani@avagotech.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.1.2016 07:37, Suganath prabu Subaramani wrote: > From: Suganath prabu Subramani > > 1.Wrong size of argument is being passed > The size of struct being passed as an argument to memset func and area of > memory being pointed by an instance of struct in memset func should be of > same structure type. > 2.Dereference null return value > 3.Array compared against '0' > Check whether value pointed by particular index of an array is null or not > in "if" statement. > > Signed-off-by: Suganath prabu Subramani > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas