From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966018AbcBDPBO (ORCPT ); Thu, 4 Feb 2016 10:01:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965649AbcBDPBN (ORCPT ); Thu, 4 Feb 2016 10:01:13 -0500 Subject: Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter. To: Suganath prabu Subaramani , JBottomley@Parallels.com, jejb@kernel.org, hch@infradead.org References: <1453963027-19770-1-git-send-email-suganath-prabu.subramani@avagotech.com> <1453963027-19770-7-git-send-email-suganath-prabu.subramani@avagotech.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Sathya.Prakash@avagotech.com, kashyap.desai@avagotech.com, krishnaraddi.mankani@avagotech.com, linux-kernel@vger.kernel.org, chaitra.basappa@avagotech.com, sreekanth.reddy@avagotech.com From: Tomas Henzl Message-ID: <56B367B5.5030001@redhat.com> Date: Thu, 4 Feb 2016 16:01:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1453963027-19770-7-git-send-email-suganath-prabu.subramani@avagotech.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.1.2016 07:37, Suganath prabu Subaramani wrote: > From: Suganath prabu Subramani > > Module parameter to enable/disable configuring > affinity hint for msix vector. > SMP affinity feature can be enabled/disabled by setting > module parameter "smp_affinity_enable" to 1/0. > By default this feature is enabled. (smp_affinity_enable = 1 enabled). > > Signed-off-by: Suganath prabu Subramani > Signed-off-by: Chaitra P B > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 34 +++++++++++++++++++++++----------- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 31838d9a..a1a3b39 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -83,6 +83,10 @@ static int msix_disable = -1; > module_param(msix_disable, int, 0); > MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)"); > > +static int smp_affinity_enable = 1; > +module_param(smp_affinity_enable, int, S_IRUGO); > +MODULE_PARM_DESC(smp_affinity_enable, "SMP affinity feature enable/disbale Default: enable(1)"); > + > static int max_msix_vectors = -1; > module_param(max_msix_vectors, int, 0); > MODULE_PARM_DESC(max_msix_vectors, > @@ -1812,8 +1816,10 @@ _base_free_irq(struct MPT3SAS_ADAPTER *ioc) > > list_for_each_entry_safe(reply_q, next, &ioc->reply_queue_list, list) { > list_del(&reply_q->list); > - irq_set_affinity_hint(reply_q->vector, NULL); > - free_cpumask_var(reply_q->affinity_hint); > + if (smp_affinity_enable) { > + irq_set_affinity_hint(reply_q->vector, NULL); > + free_cpumask_var(reply_q->affinity_hint); > + } > synchronize_irq(reply_q->vector); > free_irq(reply_q->vector, reply_q); > kfree(reply_q); > @@ -1844,9 +1850,11 @@ _base_request_irq(struct MPT3SAS_ADAPTER *ioc, u8 index, u32 vector) > reply_q->msix_index = index; > reply_q->vector = vector; > > - if (!alloc_cpumask_var(&reply_q->affinity_hint, GFP_KERNEL)) > - return -ENOMEM; > - cpumask_clear(reply_q->affinity_hint); > + if (smp_affinity_enable) { > + if (!alloc_cpumask_var(&reply_q->affinity_hint, GFP_KERNEL)) a kfree(reply_q); should go here > + return -ENOMEM; > + cpumask_clear(reply_q->affinity_hint); maybe zalloc_cpumask_var ? > + } if (r) { pr_err(MPT3SAS_FMT "unable to allocate interrupt %d!\n", reply_q->name, vector); kfree(reply_q); and a free_cpumask_var (..) here ? return -EBUSY; cheers, tomash