From: Tyrel Datwyler <turtle.in.the.kernel@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
JBottomley@odin.com, linux-kernel@vger.kernel.org, hare@suse.de,
brking@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface
Date: Thu, 4 Feb 2016 09:48:23 -0800 [thread overview]
Message-ID: <56B38EE7.6060102@gmail.com> (raw)
In-Reply-To: <20160204080317.GT27969@c203.arch.suse.de>
On 02/04/2016 12:03 AM, Johannes Thumshirn wrote:
> On Wed, Feb 03, 2016 at 05:28:33PM -0600, Tyrel Datwyler wrote:
>> A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in
>> the code for some time. From what information I've gathered from
>> Brian King this was likely implemented on the host side in a SLES 9
>> based VIOS, which is no longer supported anywhere. Further, it is
>> not defined in PAPR or supported by any AIX based VIOS.
>>
>> Treating as bit rot and removing the sysfs interface and associated
>> host config code accordingly.
>
> Doesn't removing a sysfs interface potentially break userspace code?
>
In the general case yes, but I feel in this case no. First, Reading from
this config attribute of a vscsi host adapter always returns nothing.
Second, any userspace code using this attribute better be checking for
the existence of config. Just a quick look for
/sys/class/scsi_host/host*/config under other host adapters on my system
I find that attribute doesn't exist for any of them.
If there is truly enough concern that somebody may actually be accessing
this useless attribute from userspace then we can still strip out the
unsupported code, but leave the attribute and return nothing directly
from the show function.
-Tyrel
next prev parent reply other threads:[~2016-02-04 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 23:28 [PATCH 0/6] ibmvscsi: code cleanup Tyrel Datwyler
2016-02-03 23:28 ` [PATCH 1/6] ibmvscsi: Correct values for several viosrp_crq_format enums Tyrel Datwyler
2016-02-04 8:38 ` Johannes Thumshirn
2016-02-03 23:28 ` [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values Tyrel Datwyler
2016-02-04 8:39 ` Johannes Thumshirn
2016-02-04 19:55 ` Manoj Kumar
2016-02-04 21:25 ` Tyrel Datwyler
2016-02-09 17:41 ` Manoj Kumar
2016-02-09 18:27 ` Tyrel Datwyler
2016-02-03 23:28 ` [PATCH 3/6] ibmvscsi: Replace magic values in set_adpater_info() with defines Tyrel Datwyler
2016-02-04 8:44 ` Johannes Thumshirn
2016-02-03 23:28 ` [PATCH 4/6] ibmvscsi: Use of_root to access OF device tree root node Tyrel Datwyler
2016-02-04 8:45 ` Johannes Thumshirn
2016-02-03 23:28 ` [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface Tyrel Datwyler
2016-02-04 8:03 ` Johannes Thumshirn
2016-02-04 17:48 ` Tyrel Datwyler [this message]
2016-02-05 8:34 ` Johannes Thumshirn
2016-02-03 23:28 ` [PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute show functions Tyrel Datwyler
2016-02-04 8:45 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B38EE7.6060102@gmail.com \
--to=turtle.in.the.kernel@gmail.com \
--cc=JBottomley@odin.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).