From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753431AbcBENcN (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Feb 2016 08:32:13 -0500
Received: from mail-lf0-f53.google.com ([209.85.215.53]:36191 "EHLO
	mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753366AbcBENcK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Feb 2016 08:32:10 -0500
Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for the PIC32 SPI
 peripheral
To: Purna Chandra Mandal <purna.mandal@microchip.com>,
        Joshua Henderson <joshua.henderson@microchip.com>,
        linux-kernel@vger.kernel.org
References: <1454366701-10847-1-git-send-email-joshua.henderson@microchip.com>
 <56B08EEB.3050808@cogentembedded.com> <56B42E4C.8040201@microchip.com>
Cc: linux-mips@linux-mips.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56B4A457.7050807@cogentembedded.com>
Date: Fri, 5 Feb 2016 16:32:07 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56B42E4C.8040201@microchip.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 2/5/2016 8:08 AM, Purna Chandra Mandal wrote:

>>> From: Purna Chandra Mandal <purna.mandal@microchip.com>
>>> Document the devicetree bindings for the SPI peripheral found
>>> on Microchip PIC32 class devices.
>>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>>> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
>>> ---
>>>    .../bindings/spi/microchip,spi-pic32.txt           |   44 ++++++++++++++++++++
>>>    1 file changed, 44 insertions(+)
>>>    create mode 100644 Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
>>> diff --git a/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
>>> new file mode 100644
>>> index 0000000..a555618
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/spi/microchip,spi-pic32.txt
>>> @@ -0,0 +1,44 @@
>>> +* Microchip PIC32 SPI device

[...]

>>> +Example:
>>> +
>>> +    spi1:spi@0x1f821000 {
>> Please insert spaces after colon.

> ack

    And please drop "0x" from the <unit-address> part of the name.

MBR, Sergei