From: Jonathan Cameron <jic23@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>,
gregkh@linuxfoundation.org, lars@metafoo.de,
Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:iio:Remove exceptional & on function name
Date: Sat, 6 Feb 2016 18:19:06 +0000 [thread overview]
Message-ID: <56B6391A.9040508@kernel.org> (raw)
In-Reply-To: <1454644412-6861-1-git-send-email-bhumirks@gmail.com>
On 05/02/16 03:53, Bhumika Goyal wrote:
> In this file,function names are otherwise used as pointers without &.
> Found using coccinelle.
> // <smpl>
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> // </smpl>
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Nice little bit of tidying up.
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 10c43dda..d1218d8 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -558,7 +558,7 @@ out:
> }
>
> static const struct iio_info ad5933_info = {
> - .read_raw = &ad5933_read_raw,
> + .read_raw = ad5933_read_raw,
> .attrs = &ad5933_attribute_group,
> .driver_module = THIS_MODULE,
> };
> @@ -616,9 +616,9 @@ static int ad5933_ring_postdisable(struct iio_dev *indio_dev)
> }
>
> static const struct iio_buffer_setup_ops ad5933_ring_setup_ops = {
> - .preenable = &ad5933_ring_preenable,
> - .postenable = &ad5933_ring_postenable,
> - .postdisable = &ad5933_ring_postdisable,
> + .preenable = ad5933_ring_preenable,
> + .postenable = ad5933_ring_postenable,
> + .postdisable = ad5933_ring_postdisable,
> };
>
> static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
>
prev parent reply other threads:[~2016-02-06 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 3:53 [PATCH] Staging:iio:Remove exceptional & on function name Bhumika Goyal
2016-02-06 18:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B6391A.9040508@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).