From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752576AbcBHNzY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 08:55:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59643 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752328AbcBHNzT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 08:55:19 -0500
Subject: Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable
 Chain Frame Size
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
References: <1453963027-19770-1-git-send-email-suganath-prabu.subramani@avagotech.com>
 <1453963027-19770-8-git-send-email-suganath-prabu.subramani@avagotech.com>
 <56B368C2.8080607@redhat.com>
 <CAK=zhgpHxib0kcXXRH7o-dRew0aUwFTdAXsLxOun4RZVgsw+Rw@mail.gmail.com>
Cc: Suganath prabu Subaramani 
	<suganath-prabu.subramani@avagotech.com>,
        "jejb@kernel.org" <jejb@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        Sathya Prakash <Sathya.Prakash@avagotech.com>,
        Kashyap Desai <kashyap.desai@avagotech.com>,
        Krishnaraddi Mankani <krishnaraddi.mankani@avagotech.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chaitra Basappa <chaitra.basappa@avagotech.com>,
        Sreekanth Reddy <sreekanth.reddy@avagotech.com>
From: Tomas Henzl <thenzl@redhat.com>
Message-ID: <56B89E41.5090500@redhat.com>
Date: Mon, 8 Feb 2016 14:55:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAK=zhgpHxib0kcXXRH7o-dRew0aUwFTdAXsLxOun4RZVgsw+Rw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5.2.2016 08:56, Sreekanth Reddy wrote:
> On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl <thenzl@redhat.com> wrote:
>> On 28.1.2016 07:37, Suganath prabu Subaramani wrote:
>>> From: Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
>>>
>>> Added support for configurable Chain Frame Size. Calculate the
>>> Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts).
>>> Applicable only for mpt3sas/SAS3.0 HBA's.
>>>
>>> Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
>>> Signed-off-by: Chaitra P B <chaitra.basappa@avagotech.com>
>> Is this done in order to prepare for some future patch, or how  does it work?
>> I noticed only changes in allocation of (probably larger) fields, but
>> how is it actually used ?
> Tomas,
>
> In this patch set we have added new Intruder and Cutlass (high ports)
> PCI devices which are based on MPI26 version.
> In this MPI26 version, Request Frame size is doubled when compared to
> older MPI version, but their is
> no change in the Chain buffer size from MPI26 to older versions. In
> older version Request frame size and
> chain buffer size were same, so in the drivers previously we used to
> use Request Frame size reference for
> Chain buffer size. But we can't use that reference now. So now we are
> determining the chain buffer size from
> IOCFact's IOCMaxChainSegementSize field instead of using the Request
> frame size reference.
>
> ~Sreekanth

Thanks,

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas