From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbcBKMOn (ORCPT ); Thu, 11 Feb 2016 07:14:43 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:59525 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcBKMOm (ORCPT ); Thu, 11 Feb 2016 07:14:42 -0500 X-CTCH-RefID: str=0001.0A0C0202.56BC7B2C.0028,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header To: "Maciej W. Rozycki" , Ralf Baechle References: <56BAD881.9000208@bmw-carit.de> <1455096081-7176-1-git-send-email-daniel.wagner@bmw-carit.de> <1455096081-7176-3-git-send-email-daniel.wagner@bmw-carit.de> <20160211104903.GD11091@linux-mips.org> CC: , From: Daniel Wagner Message-ID: <56BC7B2B.9010605@bmw-carit.de> Date: Thu, 11 Feb 2016 13:14:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="iso-8859-7" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 01:04 PM, Maciej W. Rozycki wrote: > On Thu, 11 Feb 2016, Ralf Baechle wrote: >> Thanks, applied. >> >> I'm getting a less spectacular warning from gcc 5.2: >> >> CC fs/proc/vmcore.o >> fs/proc/vmcore.c: In function ¡parse_crash_elf64_headers¢: >> fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > > Yes, the temporaries still need to have their pointed types changed, to > `Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change. > > I had it mentioned in a WIP version of my review (stating that it would > verify that the correct type is used by the caller), but then deleted that > part inadvertently, sigh. Yeah, that part fall through the cracks. > Daniel, sorry for the extra iteration. No problem. Just a sec. cheers, daniel