From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752440AbcBOI3S (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 03:29:18 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:16044 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752085AbcBOI3Q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 03:29:16 -0500
Subject: Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware
 SPI driver
To: Mark Brown <broonie@kernel.org>, qiujiang <qiujiang@huawei.com>
References: <1454656280-130658-1-git-send-email-qiujiang@huawei.com>
 <20160205110900.GA12311@sirena.org.uk>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <charles.chenxin@huawei.com>, <linuxarm@huawei.com>,
        <linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        <linux-spi@vger.kernel.org>
From: Hanjun Guo <guohanjun@huawei.com>
Message-ID: <56C18C07.2030209@huawei.com>
Date: Mon, 15 Feb 2016 16:27:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160205110900.GA12311@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.17.188]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.56C18C4C.0057,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 426e48ccdc54e9378a98391b9a5bca51
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/2/5 19:09, Mark Brown wrote:
> On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote:
>
>> This patch added ACPI support for DesignWare SPI mmio driver. It
>> was based the corresponding DT driver and compatible for this two
>> way. This patch has been tested on Hisilicon D02 board. It relies
>> on the GPIO patchset.
> Intel are heavy users of this driver on their systems which also use
> ACPI.  Have you discussed this binding with them?  I've copied Andy and
> Jarkko who've worked on the driver recently.

There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
this driver directly.

[...]
>
>> +static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
>> +		{"HISI0171", 0},
>> +		{ }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> I really do wish ACPI had some more sensible system for allocating
> device IDs so the tables were a little more legible. :(

Hmm, I agree. but for now, every OEM can request ACPI or PNP ID with specific
prefixes, and they can manage it by themselves, that would flexible for OEM verdors
to develop firmware and driver.

For this driver in particular, if DesignWare provides the ACPI or PNP ID, that would
be great for all OEMs can reuse it.

Thanks
Hanjun