From: xuejiancheng <xuejiancheng@huawei.com>
To: Michael Turquette <mturquette@baylibre.com>,
<sboyd@codeaurora.org>, <p.zabel@pengutronix.de>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
<khilman@linaro.org>, <arnd@arndb.de>, <olof@lixom.net>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
<suwenping@hisilicon.com>, <raojun@hisilicon.com>,
<ml.yang@hisilicon.com>, <gaofei@hisilicon.com>,
<zhangzhenxing@hisilicon.com>, <xuejiancheng@hisilicon.com>,
<lidongpo@hisilicon.com>
Subject: Re: [RESEND PATCH v8 1/6] clk: hisilicon: add CRG driver for hi3519 soc
Date: Wed, 17 Feb 2016 11:08:19 +0800 [thread overview]
Message-ID: <56C3E423.5080801@huawei.com> (raw)
In-Reply-To: <20160217004648.2278.64006@quark.deferred.io>
Hi Mike,
Thank you very much for your comments.
On 2016/2/17 8:46, Michael Turquette wrote:
> Hello Jiancheng Xue,
>
> Quoting Jiancheng Xue (2016-02-04 18:31:07)
>> diff --git a/drivers/clk/hisilicon/Makefile b/drivers/clk/hisilicon/Makefile
>> index 74dba31..3f57b09 100644
>> --- a/drivers/clk/hisilicon/Makefile
>> +++ b/drivers/clk/hisilicon/Makefile
>> @@ -4,8 +4,10 @@
>>
>> obj-y += clk.o clkgate-separated.o clkdivider-hi6220.o
>>
>> +obj-$(CONFIG_RESET_CONTROLLER) += reset.o
>
> Do you really want to build reset.o for all hisi SoCs?
>
This reset controller driver will be just used in some of hisilicon SOCs.
I'll add a specific config item for it like CONFIG_RESET_HISI. The config
item will be selected by default in SOCs needing this driver.
I'll also fix other issues in next version. Thank you!
Regards,
Jiancheng.
next prev parent reply other threads:[~2016-02-17 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 2:31 [RESEND PATCH v8 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2016-02-05 2:31 ` [RESEND PATCH v8 1/6] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2016-02-17 0:46 ` Michael Turquette
2016-02-17 3:08 ` xuejiancheng [this message]
2016-02-05 2:31 ` [RESEND PATCH v8 2/6] ARM: hisi: add compatible string for Hi3519 soc Jiancheng Xue
2016-02-05 2:31 ` [RESEND PATCH v8 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue
2016-02-05 2:31 ` [RESEND PATCH v8 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue
2016-02-05 2:31 ` [RESEND PATCH v8 5/6] ARM: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2016-02-05 2:31 ` [RESEND PATCH v8 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3E423.5080801@huawei.com \
--to=xuejiancheng@huawei.com \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gaofei@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=lidongpo@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ml.yang@hisilicon.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=raojun@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=suwenping@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=yanghongwei@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhangzhenxing@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).