From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbcCKT3r (ORCPT ); Fri, 11 Mar 2016 14:29:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45207 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932070AbcCKT3p (ORCPT ); Fri, 11 Mar 2016 14:29:45 -0500 Subject: Re: [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface To: Vinod Koul References: <1454646882-24369-1-git-send-email-okaya@codeaurora.org> <1454646882-24369-6-git-send-email-okaya@codeaurora.org> <20160311020650.GG11154@localhost> <56E2EC1C.6040107@codeaurora.org> <20160311163221.GC13211@localhost> <56E2F5EA.10207@codeaurora.org> Cc: dmaengine@vger.kernel.org, marc.zyngier@arm.com, mark.rutland@arm.com, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, shankerd@codeaurora.org, vikrams@codeaurora.org, eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <56E31CA5.6040106@codeaurora.org> Date: Fri, 11 Mar 2016 14:29:41 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E2F5EA.10207@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/2016 11:44 AM, Sinan Kaya wrote: > On 3/11/2016 11:32 AM, Vinod Koul wrote: >>>>> memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], >>>>>>>> + TRE_SIZE); >> This one >> >>>>>>>> + lldev->tx_status_list[tre->idx].err_code = 0; >>>>>>>> + lldev->tx_status_list[tre->idx].err_info = 0; >>>>>>>> + tre->queued = 1; >>>>>>>> + lldev->pending_tre_count++; >>>> >>>> Is this the only one without alignment? I couldn't understand what you mean by >>>> above one? >> quoting Coding Style: >> >> Statements longer than 80 columns will be broken into sensible chunks, unless >> exceeding 80 columns significantly increases readability and does not hide >> information. > >> "Descendants are always substantially shorter than the parent and >> are placed substantially to the right." >> >> > > Sorry for my poor English. I never got this rule. > > Which one is a "substantially" right? Can you give me an example? > > I need to understand how you'd write this to satisfy the above rule. > > like this: > > memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], > TRE_SIZE); > > or > > memcpy(lldev->tre_ring + lldev->tre_write_offset, > &tre->tre_local[0], TRE_SIZE); > > or > > memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], > TRE_SIZE); > > or > > memcpy(lldev->tre_ring + lldev->tre_write_offset, > &tre->tre_local[0], > TRE_SIZE); > so, I looked at other examples in drivers/dma/dw/core.c file... I'm seeing two different patterns in the code. One pattern is to align the next line to the first character of the first line like I did based on the previous review comments. mem_width = min_t(unsigned int, data_width, dwc_fast_ffs(mem | len)); The second example places an extra tab like this. list_add_tail(&desc->desc_node, &first->tx_list); Based on this example: this is how I'm changing the second one + lldev->tre_write_offset = (lldev->tre_write_offset + HIDMA_TRE_SIZE) + % lldev->tre_ring_size; + I'm still not sure what you want to do with this: Is this what you want to do ? memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], - HIDMA_TRE_SIZE); + HIDMA_TRE_SIZE); I also got flagged before that HIDMA_TRE_SIZE does not start from the first character. I have done the renaming. This is all left for me to post a follow up. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project