From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934221AbcCNN4I (ORCPT ); Mon, 14 Mar 2016 09:56:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35064 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932123AbcCNN4F (ORCPT ); Mon, 14 Mar 2016 09:56:05 -0400 Subject: Re: [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface To: Vinod Koul References: <1454646882-24369-1-git-send-email-okaya@codeaurora.org> <1454646882-24369-6-git-send-email-okaya@codeaurora.org> <20160311020650.GG11154@localhost> <56E2EC1C.6040107@codeaurora.org> <20160311163221.GC13211@localhost> <56E2F5EA.10207@codeaurora.org> <56E31CA5.6040106@codeaurora.org> <20160313155933.GD13211@localhost> Cc: dmaengine@vger.kernel.org, marc.zyngier@arm.com, mark.rutland@arm.com, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, shankerd@codeaurora.org, vikrams@codeaurora.org, eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <56E6C2F1.7070504@codeaurora.org> Date: Mon, 14 Mar 2016 09:56:01 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160313155933.GD13211@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, On 3/13/2016 11:59 AM, Vinod Koul wrote: > I would write this as: > > memcpy(lldev->tre_ring + lldev->tre_write_offset, > &tre->tre_local[0], TRE_SIZE); > > To make it look more readable Got it. > >>>> > >> >>>>>>>>>> > >>>>>>>> + lldev->tx_status_list[tre->idx].err_code = 0; >>>>>>>>>> > >>>>>>>> + lldev->tx_status_list[tre->idx].err_info = 0; >>>>>>>>>> > >>>>>>>> + tre->queued = 1; >>>>>>>>>> > >>>>>>>> + lldev->pending_tre_count++; >>>>>> > >>>> >>>>>> > >>>> Is this the only one without alignment? I couldn't understand what you mean by >>>>>> > >>>> above one? >>>> > >> quoting Coding Style: >>>> > >> >>>> > >> Statements longer than 80 columns will be broken into sensible chunks, unless >>>> > >> exceeding 80 columns significantly increases readability and does not hide >>>> > >> information. >>> > > >>>> > >> "Descendants are always substantially shorter than the parent and >>>> > >> are placed substantially to the right." >>>> > >> >>>> > >> >>> > > >>> > > Sorry for my poor English. I never got this rule. >>> > > >>> > > Which one is a "substantially" right? Can you give me an example? >>> > > >>> > > I need to understand how you'd write this to satisfy the above rule. >>> > > >>> > > like this: >>> > > >>> > > memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], >>> > > TRE_SIZE); > No > >>> > > >>> > > or >>> > > >>> > > memcpy(lldev->tre_ring + lldev->tre_write_offset, >>> > > &tre->tre_local[0], TRE_SIZE); > Better or above > I'll do this to be consistent with the rest of the code. Please let me know when you want to have the updated version. I don't want to post v16 while you are reviewing the rest of the code. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project