From: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
To: Drew Fustini <dfustini@tenstorrent.com>,
Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Yangtao Li <frank.li@vivo.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH RFC v2 0/4] clk: thead: Add support for TH1520 AP_SUBSYS clock controller
Date: Thu, 2 May 2024 09:47:38 +0200 [thread overview]
Message-ID: <588fb903-e5ca-43af-9258-c14aaab6c732@bootlin.com> (raw)
In-Reply-To: <20240426-th1520-clk-v2-v2-0-96b829e6fcee@tenstorrent.com>
On 4/27/24 2:10 AM, Drew Fustini wrote:
> This series adds support for the AP sub-system clock controller in the
> T-Head TH1520 [1]. Yangtao Li originally submitted this series in May
> 2023 [2]. Jisheng made additional improvements and then passed on the
> work in progress to me.
>
> Changes I made from the original series:
> - corrected the npu_clk enable bit
> - deduplicated CLK_NPU and CLK_NPU_AXI number in header
> - fixed c910_i0_clk reg typo
> - fixed checkpatch and dt_binding_check warnings
> - rebased on v6.9-rc5
> - revised commit descriptions
>
> Changes since my RFC v1 [4]:
> - squash the header file patch into the DT schema patch
> - describe the changes I made to original series in the cover letter
> instead of the individual patches
> - fix my typo in my email address
>
> TODO:
> I am again marking this as an RFC because there is feedback from v1 that
> I have not yet addressed. I am posting what I currently have as other
> patch series like the TH1520 I2C driver [4] could use the clk driver.
>
> Emil commented that the input predivider is not handled correctly in
> ccu_mdiv_recalc_rate(). The PLL multiplies the input frequency and
> outputs "Foutvco". This is followed by a post divider to produce
> "Foutpostdiv". However, some clocks derive directly from the "Foutvco"
> Emil suggested this should really be modeled as two different clocks.
>
> Emil aslo suggested that the rest of the clocks in this driver seem to
> be generic gate and mux implementations that should probably be replaced
> with devm_clk_hw_register_gate*() and devm_clk_hw_register_mux*().
>
> I'll look to address the above issues in the next revision.
>
> Thank you,
> Drew
>
> [1] https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf
> [2] https://lore.kernel.org/linux-riscv/20230515054402.27633-1-frank.li@vivo.com/
> [3] https://lore.kernel.org/lkml/20240110-clk-th1520-v1-0-8b0682567984@tenstorrent.com/
> [4] https://lore.kernel.org/linux-riscv/20240425082138.374445-1-thomas.bonnefille@bootlin.com/
Thank you ! It works on the Beagle-V Ahead :)
Tested-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
prev parent reply other threads:[~2024-05-02 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 0:10 [PATCH RFC v2 0/4] clk: thead: Add support for TH1520 AP_SUBSYS clock controller Drew Fustini
2024-04-27 0:10 ` [PATCH RFC v2 1/4] dt-bindings: clock: Document T-Head TH1520 AP_SUBSYS controller Drew Fustini
2024-04-29 5:10 ` Krzysztof Kozlowski
2024-04-27 0:10 ` [PATCH RFC v2 2/4] clk: thead: Add support for T-Head TH1520 AP_SUBSYS clocks Drew Fustini
2024-05-02 7:47 ` Thomas Bonnefille
2024-04-27 0:10 ` [PATCH RFC v2 3/4] riscv: dts: thead: Add TH1520 AP_SUBSYS clock controller Drew Fustini
2024-04-27 0:10 ` [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers Drew Fustini
2024-05-02 7:47 ` Thomas Bonnefille
2024-05-02 15:53 ` Drew Fustini
2024-05-03 6:58 ` Thomas Bonnefille
2024-05-02 7:47 ` Thomas Bonnefille [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588fb903-e5ca-43af-9258-c14aaab6c732@bootlin.com \
--to=thomas.bonnefille@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=emil.renner.berthing@canonical.com \
--cc=frank.li@vivo.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).