From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CED4C7EE45 for ; Fri, 9 Jun 2023 19:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231777AbjFITbM (ORCPT ); Fri, 9 Jun 2023 15:31:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjFITbI (ORCPT ); Fri, 9 Jun 2023 15:31:08 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A1812D44 for ; Fri, 9 Jun 2023 12:31:07 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9745d99cfccso359468066b.1 for ; Fri, 09 Jun 2023 12:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686339066; x=1688931066; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DliK5Hp5RoZMubfG2AiJ9X+1ugEJQb3FPewKfTexS7w=; b=bCOv1PBRv5EuN82ku5W4DhPb7+JPx+hrv+GJ+/nt6Glk+8NsQxyMpmLo8JpOtdJlQe qHyBcrPrNKcYAyGB/35ZgtG9eW7AgfBUWsUOjd3Gsyw7xCtKamNRL7iKVNcvQX1MHzP3 T0x5Vd5D4KREHAJpGXw3uaUmbVa+Jq79OhLOrseW69ZI+B7iNJ5iltCdJrs1M6id/lNB kB5a3zafD6u4ne5yYSAquqRDV9eXz6VO8lS2A+E12nydmju9sfLzlrUjbFwfgRMnXcxI bqB3HR+QDOCdlcd36J3goaU/ePvrjUuKt8baxEBi00wgO0K4agq6rKOP1+/y3QYYWII6 gTCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686339066; x=1688931066; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DliK5Hp5RoZMubfG2AiJ9X+1ugEJQb3FPewKfTexS7w=; b=JMlAOhxPRPJGKT63+hHZU6Z/AEWgD6An3J9xiUqLZ7+E2iJumYkeO1Aek9viMvTxRv 4KNhMVetYHb5NE4gCAOH4bxWv0E9+F2OuMlcW/4j3+3UVq+ZBoMRPW0OwgYeeVN7uOiP gbE86z6i1WKv6IcAdNypk/ED/nBvGunttjmK0VEMOdyT4/VWf6nTxXgnw06cHV8yW3c/ IGjyn9MNKtfvKwASIi9q3KpCBjWyAlKbE14I2vUxjpIz5tPLcGfbR4WvpK9rlF12utz4 1zA3tbAd7NyN+YOgVof5UduWKVqqs/gNsP0cQhqw/2UCXkwZh59AQgRdiP4m6YgwqEEa djTQ== X-Gm-Message-State: AC+VfDydn/JL7weIWOeKiOAC2mxXcSZVt34XV8wSIREsvrg2bfLBX2l7 +nScvCOx8yVbiJKWzIFeuQqnNQ== X-Google-Smtp-Source: ACHHUZ5/kIn8quJT6E08siRRrzbmgtYPkciUGjRvxv52jycK2IvUzHGqi09YeWBNH1BhvQU6Pq/cIw== X-Received: by 2002:a17:907:86a4:b0:970:1a68:bacc with SMTP id qa36-20020a17090786a400b009701a68baccmr3059925ejc.67.1686339065818; Fri, 09 Jun 2023 12:31:05 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id p22-20020a170906229600b009745c628bcdsm1641778eja.93.2023.06.09.12.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 12:31:05 -0700 (PDT) Message-ID: <5dc0b50c-611a-187a-2f91-dec0dcecde78@linaro.org> Date: Fri, 9 Jun 2023 21:31:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply Content-Language: en-US To: Raymond Hackley , linux-kernel@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Liam Girdwood , Mark Brown , Michael Walle , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jeremy Kerr , netdev@vger.kernel.org, devicetree@vger.kernel.org References: <20230609182639.85034-1-raymondhackley@protonmail.com> <20230609182729.85088-1-raymondhackley@protonmail.com> <20230609182729.85088-2-raymondhackley@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230609182729.85088-2-raymondhackley@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2023 20:28, Raymond Hackley wrote: > PN547/553, QN310/330 chips on some devices require a pad supply voltage > (PVDD). Otherwise, the NFC won't power up. > > Implement support for pad supply voltage pvdd-supply that is enabled by > the nxp-nci driver so that the regulator gets enabled when needed. > > Signed-off-by: Raymond Hackley > --- > drivers/nfc/nxp-nci/i2c.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c > index d4c299be7949..6f01152d2c83 100644 > --- a/drivers/nfc/nxp-nci/i2c.c > +++ b/drivers/nfc/nxp-nci/i2c.c > @@ -35,6 +35,7 @@ struct nxp_nci_i2c_phy { > > struct gpio_desc *gpiod_en; > struct gpio_desc *gpiod_fw; > + struct regulator *pvdd; > > int hard_fault; /* > * < 0 if hardware error occurred (e.g. i2c err) > @@ -263,6 +264,20 @@ static const struct acpi_gpio_mapping acpi_nxp_nci_gpios[] = { > { } > }; > > +static void nxp_nci_i2c_poweroff(void *data) > +{ > + struct nxp_nci_i2c_phy *phy = data; > + struct device *dev = &phy->i2c_dev->dev; > + struct regulator *pvdd = phy->pvdd; > + int r; > + > + if (!IS_ERR(pvdd) && regulator_is_enabled(pvdd)) { No, don't send a new version before we finish discussion. One version per day is enough. NAK for this part, same reasons as before. Best regards, Krzysztof