LKML Archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Gjorgji Rosikopulos <quic_grosikop@quicinc.com>,
	rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org,
	konrad.dybcio@linaro.org, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com
Subject: Re: [PATCH v2 0/8] Move camss version related defs in to resources
Date: Mon, 1 Apr 2024 23:35:50 +0100	[thread overview]
Message-ID: <60461c7b-b693-4560-ab29-8cd9d8ac4a44@linaro.org> (raw)
In-Reply-To: <20240319173935.481-1-quic_grosikop@quicinc.com>

On 19/03/2024 17:39, Gjorgji Rosikopulos wrote:
> The different resources required for different camss soc versions are
> split in to two groups:

General series comment =>

You need to add your Signed-off-by: Gjorgji Rosikopulos 
<quic_grosikop@quicinc.com>

for each of the patches you are submitting.

Perhaps yourself or some of the other people in the series deserve to 
have Co-developed-by for some of the patches too ?

I really like the reduction of code and the definition in one-place of 
things so definitely the right direction.

I won't do a deeper dive into the code until V3 but for reference here 
are the branches I verified db410c, rb3, rb5 and x13s with.

x13s:
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/sc8280xp-6.9-rc1-camss-resource-change-verification?ref_type=heads

db410c/rb3/rb5:
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-stable-v6.7.9-camss-rb5-20240319173935.481-1-quic_grosikop@quicinc.com?ref_type=heads

---
bod

  parent reply	other threads:[~2024-04-01 22:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 17:39 [PATCH v2 0/8] Move camss version related defs in to resources Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 1/8] media: qcom: camss: Add per sub-device type resources Gjorgji Rosikopulos
2024-04-01 22:30   ` Bryan O'Donoghue
2024-03-19 17:39 ` [PATCH v2 2/8] media: qcom: camss: Attach formats to VFE resources Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 3/8] media: qcom: camss: Attach formats to CSID resources Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 4/8] media: qcom: camss: Attach formats to CSIPHY resources Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 5/8] media: qcom: camss: Move format related functions Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 6/8] media: qcom: camss: Split testgen, RDI and RX for CSID 170 Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 7/8] media: qcom: camss: Decompose register and link operations Gjorgji Rosikopulos
2024-03-19 17:39 ` [PATCH v2 8/8] media: qcom: camss: Decouple VFE from CSID Gjorgji Rosikopulos
2024-04-01 22:35 ` Bryan O'Donoghue [this message]
2024-04-03  9:54   ` [PATCH v2 0/8] Move camss version related defs in to resources Gjorgji Rosikopulos (Consultant)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60461c7b-b693-4560-ab29-8cd9d8ac4a44@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=konrad.dybcio@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_grosikop@quicinc.com \
    --cc=quic_hariramp@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).