From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043F3C433B4 for ; Wed, 7 Apr 2021 03:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C81E3613C6 for ; Wed, 7 Apr 2021 03:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344040AbhDGDF5 (ORCPT ); Tue, 6 Apr 2021 23:05:57 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3935 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhDGDFz (ORCPT ); Tue, 6 Apr 2021 23:05:55 -0400 Received: from DGGEML401-HUB.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FFTjy5nYsz5mZL; Wed, 7 Apr 2021 11:03:34 +0800 (CST) Received: from dggpeml500013.china.huawei.com (7.185.36.41) by DGGEML401-HUB.china.huawei.com (10.3.17.32) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 7 Apr 2021 11:05:38 +0800 Received: from [10.174.187.161] (10.174.187.161) by dggpeml500013.china.huawei.com (7.185.36.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 11:05:38 +0800 Subject: Re: [PATCH v4 01/16] perf/x86/intel: Add x86_pmu.pebs_vmx for Ice Lake Servers To: Andi Kleen References: <20210329054137.120994-2-like.xu@linux.intel.com> <606BD46F.7050903@huawei.com> <20210406124746.ji5iqladdlh73mok@two.firstfloor.org> CC: , "Fangyi (Eric)" , Xiexiangyou , , , , , From: "Liuxiangdong (Aven, Cloud Infrastructure Service Product Dept.)" Message-ID: <606D2170.6020203@huawei.com> Date: Wed, 7 Apr 2021 11:05:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20210406124746.ji5iqladdlh73mok@two.firstfloor.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.187.161] X-ClientProxiedBy: dggeme715-chm.china.huawei.com (10.1.199.111) To dggpeml500013.china.huawei.com (7.185.36.41) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/6 20:47, Andi Kleen wrote: >> AFAIKļ¼Œ Icelake supports adaptive PEBS and extended PEBS which Skylake >> doesn't. >> But we can still use IA32_PEBS_ENABLE MSR to indicate general-purpose >> counter in Skylake. >> Is there anything else that only Icelake supports in this patches set? > Only Icelake server has the support for recovering from a EPT violation > on the PEBS data structures. To use it on Skylake server you would > need to pin the whole guest, but that is currently not done. Sorry. Some questions about "Pin the whole guest". Do you mean VmPin equals VmSize in "/proc/$(pidof qemu-kvm)/status"? Or just VmLck equals VmSize? Or something else? >> Besides, we have tried this patches set in Icelake. We can use pebs(eg: >> "perf record -e cycles:pp") >> when guest is kernel-5.11, but can't when kernel-4.18. Is there a minimum >> guest kernel version requirement? > You would need a guest kernel that supports Icelake server PEBS. 4.18 > would need backports for tht. > > > -Andi