From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05D7C7EE2E for ; Mon, 12 Jun 2023 22:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238743AbjFLWIE (ORCPT ); Mon, 12 Jun 2023 18:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238721AbjFLWH6 (ORCPT ); Mon, 12 Jun 2023 18:07:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08771EE; Mon, 12 Jun 2023 15:07:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 901FB62EDC; Mon, 12 Jun 2023 22:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C643C433D2; Mon, 12 Jun 2023 22:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686607676; bh=9iKK1p0kFNdxIbzsTtA0v3TwfLlhr6RY1S6PuLqz+yo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Lv+l3ef9XHrKF/2RB20fuyGBm2F7mHaqpMXlWr7I4FbQB2zt+sknQioXPSYaduVYT oH/zOm9mTR6n5a4mMvlpVeIxpSF2vEo03SOGhtbd7ojc921NN1yA8WWeoNbwFu9CVI aAvsrJwwrIbSxk849IANxD2VakGgaJ0L5+A21R36hLcXSr4KuhMPKicrir/y18Su5y dbuqErHjLN0xqeExZ9f/QuYTlDq1MxLtpU5AYjWg7rnmFFWiO7s2NLgi1ba8TnCoYR IsWaNwMMPt3x+T6i+29f+C95GTEVotQAbueM+lwxDhzD/7MClkwone/QlNh3D4PvRB of5AoLwwSHinw== Message-ID: <61beeb4f-9341-e461-57bb-7394483409fa@kernel.org> Date: Tue, 13 Jun 2023 07:07:53 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 1/3] ACPI: Move ACPI_DEVICE_CLASS() to mod_devicetable.h Content-Language: en-US To: "Rafael J. Wysocki" , Andy Shevchenko Cc: Serge Semin , Greg Kroah-Hartman , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Hans de Goede , Jens Axboe , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus References: <20230609154900.43024-1-andriy.shevchenko@linux.intel.com> <20230609154900.43024-2-andriy.shevchenko@linux.intel.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/10/23 02:32, Rafael J. Wysocki wrote: > On Fri, Jun 9, 2023 at 5:49 PM Andy Shevchenko > wrote: >> >> The data type of struct acpi_device_id is defined in the >> mod_devicetable.h. It's suboptimal to require user with >> the almost agnostic code to include acpi.h solely for the >> macro that affects the data type defined elsewhere. >> >> Taking into account the above and for the sake of consistency >> move ACPI_DEVICE_CLASS() to mod_devicetable.h. >> >> Note, that with CONFIG_ACPI=n the ID table will be filed with data >> but it does not really matter because either it won't be used, or >> won't be compiled in some cases (when guarded by respective ifdeffery). >> >> Signed-off-by: Andy Shevchenko > > Acked-by: Rafael J. Wysocki > > or please let me know if you want me to apply this. Probably better if you take the whole thing. But if needed, I can take this through the ata tree. -- Damien Le Moal Western Digital Research