From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Lee Jones <lee@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Duanqiang Wen <duanqiangwen@net-swift.com>,
"open list:SYNOPSYS DESIGNWARE I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"open list:WANGXUN ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] Define i2c_designware in a header file
Date: Thu, 25 Apr 2024 16:11:58 +0300 [thread overview]
Message-ID: <62e58960-f568-459d-8690-0c9c608a4d9f@linux.intel.com> (raw)
In-Reply-To: <20240425002642.2053657-1-florian.fainelli@broadcom.com>
On 4/25/24 3:26 AM, Florian Fainelli wrote:
> This patch series depends upon the following two patches being applied:
>
> https://lore.kernel.org/all/20240422084109.3201-1-duanqiangwen@net-swift.com/
> https://lore.kernel.org/all/20240422084109.3201-2-duanqiangwen@net-swift.com/
>
> There is no reason why each driver should have to repeat the
> "i2c_designware" string all over the place, because when that happens we
> see the reverts like the above being necessary.
>
> Changes in v2:
>
> - avoid changing i2c-designware-pcidrv.c more than necessary
> - move constant to include/linux/platform_data/i2c-designware.h
> - add comments as to how this constant is used and why
>
> Florian Fainelli (4):
> i2c: designware: Create shared header hosting driver name
> mfd: intel-lpss: Utilize i2c-designware.h
> mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h
> net: txgbe: Utilize i2c-designware.h
>
> MAINTAINERS | 1 +
> drivers/i2c/busses/i2c-designware-pcidrv.c | 3 ++-
> drivers/i2c/busses/i2c-designware-platdrv.c | 5 +++--
> drivers/mfd/intel-lpss.c | 3 ++-
> drivers/mfd/intel_quark_i2c_gpio.c | 5 +++--
> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 7 ++++---
> include/linux/platform_data/i2c-designware.h | 11 +++++++++++
> 7 files changed, 26 insertions(+), 9 deletions(-)
> create mode 100644 include/linux/platform_data/i2c-designware.h
>
I have mixed feeling about this set will it help maintaining and
developing new code or do the opposite. Surely misnaming as referenced
above can happen but I think it's not too common pattern while having
single define header put under include/ feels added burden.
Also I personally like explicit strings put into MODULE_ALIAS() since
they are easier to grep from sources and modules.alias file when
debugging autoloading issues. So change like below makes that debugging
one step more labor.
-MODULE_ALIAS("platform:i2c_designware");
+MODULE_ALIAS("platform:" I2C_DESIGNWARE_NAME);
prev parent reply other threads:[~2024-04-25 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 0:26 [PATCH v2 0/4] Define i2c_designware in a header file Florian Fainelli
2024-04-25 0:26 ` [PATCH v2 1/4] i2c: designware: Create shared header hosting driver name Florian Fainelli
2024-04-25 9:39 ` Andy Shevchenko
2024-04-25 0:26 ` [PATCH v2 2/4] mfd: intel-lpss: Utilize i2c-designware.h Florian Fainelli
2024-04-25 9:34 ` Andy Shevchenko
2024-05-02 10:00 ` Lee Jones
2024-04-25 0:26 ` [PATCH v2 3/4] mfd: intel_quark_i2c_gpio: " Florian Fainelli
2024-04-25 9:42 ` Andy Shevchenko
2024-04-25 0:26 ` [PATCH v2 4/4] net: txgbe: " Florian Fainelli
2024-04-25 9:44 ` Andy Shevchenko
2024-04-25 13:11 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e58960-f568-459d-8690-0c9c608a4d9f@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).