From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Laight <David.Laight@aculab.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
paulmck <paulmck@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
Arjun Roy <arjunroy@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()
Date: Tue, 13 Apr 2021 15:13:36 -0400 (EDT) [thread overview]
Message-ID: <64670607.73039.1618341216196.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CANn89iKhKrHgTduwUtZ6QhxE6xFcK=ijadwACg9aSEJ7QQx4Mg@mail.gmail.com>
----- On Apr 13, 2021, at 2:22 PM, Eric Dumazet edumazet@google.com wrote:
> On Tue, Apr 13, 2021 at 8:00 PM Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>>
>
>> As long as the ifdefs are localized within clearly identified wrappers in the
>> rseq code I don't mind doing the special-casing there.
>>
>> The point which remains is that I don't think we want to optimize for speed
>> on 32-bit architectures when it adds special-casing and complexity to the 32-bit
>> build. I suspect there is less and less testing performed on 32-bit
>> architectures
>> nowadays, and it's good that as much code as possible is shared between 32-bit
>> and
>> 64-bit builds to share the test coverage.
>>
>
> Quite frankly V1 was fine, I can't really make it looking better.
Yes, I'm OK with V1 of that patch.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2021-04-13 19:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 16:22 [PATCH v2 0/3] rseq: minor optimizations Eric Dumazet
2021-04-13 16:22 ` [PATCH v2 1/3] rseq: optimize rseq_update_cpu_id() Eric Dumazet
2021-04-13 16:22 ` [PATCH v2 2/3] rseq: remove redundant access_ok() Eric Dumazet
2021-04-13 16:22 ` [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs() Eric Dumazet
2021-04-13 16:54 ` Mathieu Desnoyers
2021-04-13 16:57 ` Eric Dumazet
2021-04-13 17:01 ` Eric Dumazet
2021-04-13 17:07 ` Eric Dumazet
2021-04-13 17:20 ` Mathieu Desnoyers
2021-04-13 17:33 ` Eric Dumazet
2021-04-13 18:00 ` Mathieu Desnoyers
2021-04-13 18:22 ` Eric Dumazet
2021-04-13 18:35 ` Arjun Roy
2021-04-13 21:19 ` David Laight
2021-04-13 22:03 ` Arjun Roy
2021-04-14 7:55 ` David Laight
2021-04-14 16:00 ` Eric Dumazet
2021-04-14 16:08 ` David Laight
2021-04-14 16:10 ` Eric Dumazet
2021-04-14 17:15 ` Arjun Roy
2021-04-14 17:35 ` Eric Dumazet
2021-04-14 20:15 ` Arjun Roy
2021-04-14 20:25 ` Eric Dumazet
2021-04-14 20:35 ` Arjun Roy
2021-04-13 19:13 ` Mathieu Desnoyers [this message]
2021-04-13 17:06 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64670607.73039.1618341216196.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=David.Laight@aculab.com \
--cc=arjunroy@google.com \
--cc=boqun.feng@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).