LKML Archive mirror
 help / color / mirror / Atom feed
* No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08)
@ 2024-05-02 11:04 Merlijn Wajer
  2024-05-20  7:19 ` Viresh Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: Merlijn Wajer @ 2024-05-02 11:04 UTC (permalink / raw
  To: linux-omap
  Cc: rafael, viresh.kumar, zhipeng.wang_1, Tony Lindgren,
	Ivaylo Dimitrov, Carl Philipp Klemm, Sicelo A . Mhlongo,
	linux-kernel@vger.kernel.org, linux-pm

Hi,

I was looking at switching my Motorola Droid 4 phone from Linux 6.1 to 
Linux 6.6, and it no longer gets any cpufreq entries on boot, and I 
found cpufreq_dt was no longer loaded. I tried to force the issue by 
modprobe it, but to no avail. The same issue occurs on the latest 6.9.

After a bit of digging it looks like the problem is that 
cpufreq-dt-platdev can be built as a module and when this the case 
(apparently the default), cpufreq_dt doesn't work. With the 
omap2plus_defconfig, CONFIG_CPUFREQ_DT_PLATDEV is indeed set to module.

When I manually probe cpufreq-dt-platdev and cpufreq_dt, I get the 
cpufreq_entries back.

Searching around I found this debian bug report [1] which just flips the 
CONFIG_CPUFREQ_DT_PLATDEV back to '=y', but I think there might be a 
deeper issue here.

Is there a way to define this relationship/dependency for cpufreq-dt, so 
that it will automatically load this module?

Regards,
Merlijn

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050587

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08)
  2024-05-02 11:04 No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08) Merlijn Wajer
@ 2024-05-20  7:19 ` Viresh Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2024-05-20  7:19 UTC (permalink / raw
  To: Merlijn Wajer
  Cc: linux-omap, rafael, zhipeng.wang_1, Tony Lindgren,
	Ivaylo Dimitrov, Carl Philipp Klemm, Sicelo A . Mhlongo,
	linux-kernel@vger.kernel.org, linux-pm

On 02-05-24, 13:04, Merlijn Wajer wrote:
> Hi,
> 
> I was looking at switching my Motorola Droid 4 phone from Linux 6.1 to Linux
> 6.6, and it no longer gets any cpufreq entries on boot, and I found
> cpufreq_dt was no longer loaded. I tried to force the issue by modprobe it,
> but to no avail. The same issue occurs on the latest 6.9.
> 
> After a bit of digging it looks like the problem is that cpufreq-dt-platdev
> can be built as a module and when this the case (apparently the default),
> cpufreq_dt doesn't work. With the omap2plus_defconfig,
> CONFIG_CPUFREQ_DT_PLATDEV is indeed set to module.
> 
> When I manually probe cpufreq-dt-platdev and cpufreq_dt, I get the
> cpufreq_entries back.
> 
> Searching around I found this debian bug report [1] which just flips the
> CONFIG_CPUFREQ_DT_PLATDEV back to '=y', but I think there might be a deeper
> issue here.
> 
> Is there a way to define this relationship/dependency for cpufreq-dt, so
> that it will automatically load this module?

Does this fix it for you ?

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 100760259f70..bb48b674be5e 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -233,4 +233,5 @@ static int __init cpufreq_dt_platdev_init(void)
                               sizeof(struct cpufreq_dt_platform_data)));
 }
 core_initcall(cpufreq_dt_platdev_init);
+MODULE_ALIAS("platform:cpufreq-dt");
 MODULE_LICENSE("GPL");

-- 
viresh

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-20  7:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 11:04 No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08) Merlijn Wajer
2024-05-20  7:19 ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).