LKML Archive mirror
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Tony Luck <tony.luck@intel.com>, Ira Weiny <ira.weiny@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
	Shiju Jose <shiju.jose@huawei.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	"Yazen Ghannam" <yazen.ghannam@amd.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	"Alison Schofield" <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ard Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v4 1/2] acpi/ghes: Process CXL Component Events
Date: Tue, 30 Apr 2024 11:50:46 -0700	[thread overview]
Message-ID: <66313d869fff9_1c68422945a@iweiny-mobl.notmuch> (raw)
In-Reply-To: <ZjE5O87IxxMAoaFz@agluck-desk3>

Tony Luck wrote:
> On Fri, Apr 26, 2024 at 08:34:00PM -0700, Ira Weiny wrote:
> > @@ -707,6 +805,18 @@ static bool ghes_do_proc(struct ghes *ghes,
> >  		}
> >  		else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
> >  			queued = ghes_handle_arm_hw_error(gdata, sev, sync);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_GEN_MEDIA_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_GEN_MEDIA, rec);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_DRAM_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_DRAM, rec);
> > +		} else if (guid_equal(sec_type, &CPER_SEC_CXL_MEM_MODULE_GUID)) {
> > +			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> > +			cxl_cper_post_event(CXL_CPER_EVENT_MEM_MODULE, rec);
> >  		} else {
> >  			void *err = acpi_hest_get_payload(gdata);
> 
> You pass "rec" to cxl_cper_post_event() in all these cases for later
> processing in context where you can sleep to get locks. But that's
> just a pointer somewhere into the "gdata" error record received from
> BIOS.
> 
> What's the lifetime of that record?
>

The lifetime is contained to the cxl_cper_post_envent() which does not
block.  The kfifo_put() copies the data to a cxl specific record to be
used by the CXL thread for processing.

>
> Can it be re-used/overwritten
> before that other kernel thread gets around to looking at it?

Yes because the CXL kernel thread has its own copy in the kfifo.

Ira

  reply	other threads:[~2024-04-30 18:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-27  3:33 [PATCH v4 0/2] efi/cxl-cper: Report CXL CPER events through tracing Ira Weiny
2024-04-27  3:34 ` [PATCH v4 1/2] acpi/ghes: Process CXL Component Events Ira Weiny
2024-04-29 16:24   ` Jonathan Cameron
2024-04-29 16:47   ` Ira Weiny
2024-04-30 18:32   ` Tony Luck
2024-04-30 18:50     ` Ira Weiny [this message]
2024-04-30 19:33       ` Luck, Tony
2024-05-01  6:36   ` Smita Koralahalli
2024-05-01 17:26   ` Ira Weiny
2024-04-27  3:34 ` [PATCH v4 2/2] cxl/pci: Process CPER events Ira Weiny
2024-04-29 16:25   ` Jonathan Cameron
2024-05-01  6:38   ` Smita Koralahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66313d869fff9_1c68422945a@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=Smita.KoralahalliChannabasappa@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=dan.carpenter@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shiju.jose@huawei.com \
    --cc=tony.luck@intel.com \
    --cc=vishal.l.verma@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).