LKML Archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
	linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Jameson Thies <jthies@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Benson Leung" <bleung@google.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Prashant Malani" <pmalani@chromium.org>,
	"Rajaram Regupathy" <rajaram.regupathy@intel.com>,
	"Saranya Gopal" <saranya.gopal@intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2 1/4] usb: typec: ucsi: Fix null deref in trace
Date: Thu, 25 Apr 2024 10:51:53 +0200	[thread overview]
Message-ID: <6e028bfa-9063-42ac-b40f-cf17a81c2af2@web.de> (raw)
In-Reply-To: <20240424014821.4154159-2-jthies@google.com>

…
> ucsi_register_altmode checks IS_ERR on returned pointer and treats
> NULL as valid. This results in a null deref when
> trace_ucsi_register_altmode is called.
…

Can it be nicer to use the term “null pointer dereference” for
the commit message here?

Regards,
Markus

  parent reply	other threads:[~2024-04-25  8:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24  1:48 [PATCH v2 0/4] usb: typec: ucsi: Update UCSI alternate mode Jameson Thies
2024-04-24  1:48 ` [PATCH v2 1/4] usb: typec: ucsi: Fix null deref in trace Jameson Thies
2024-04-24  2:06   ` Dmitry Baryshkov
2024-04-25  0:00     ` Abhishek Pandit-Subedi
2024-04-25  5:30       ` Christian A. Ehrhardt
2024-04-25  8:51   ` Markus Elfring [this message]
2024-04-25 19:35     ` Greg Kroah-Hartman
2024-04-30  0:43       ` Jameson Thies
2024-04-30  1:00         ` Dmitry Baryshkov
2024-04-30  1:14           ` Jameson Thies
2024-04-30  7:17   ` Dan Carpenter
2024-05-02 22:47     ` Jameson Thies
2024-05-03 12:03       ` Dan Carpenter
2024-04-24  1:48 ` [PATCH v2 2/4] usb: typec: Update sysfs when setting ops Jameson Thies
2024-04-24  1:48 ` [PATCH v2 3/4] usb: typec: ucsi: Delay alternate mode discovery Jameson Thies
2024-04-24  1:48 ` [PATCH v2 4/4] usb: typec: ucsi: Always set number of alternate modes Jameson Thies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e028bfa-9063-42ac-b40f-cf17a81c2af2@web.de \
    --to=markus.elfring@web.de \
    --cc=abhishekpandit@chromium.org \
    --cc=andersson@kernel.org \
    --cc=bleung@google.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jthies@google.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=pmalani@chromium.org \
    --cc=rajaram.regupathy@intel.com \
    --cc=saranya.gopal@intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).