From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CDA1C6A8; Thu, 25 Apr 2024 03:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714015465; cv=none; b=fyiSGMjbt1v3uVt1eF6YqimModjb6YXxPQYvMXb6OX3BiwT1wWlAANXMd1WXL+GqC+vOSd8yDqhT1Y5lYGasd18fL2+lFldWjnhy+mTwtLEd5IP/knpELCfjQeIr3QqkYL6QmKU7nEktmLOxVrS1gPNCnebeVTmppenrJQOJt8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714015465; c=relaxed/simple; bh=xqwdcJLe5JFwyevAFUDSA4T8Wpv1E+ZMopzpR7lD1Tw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=JpwlK4Sfpw217zqyR6pYYyNN7ow7gzaJg+3ubh3DaCSVKAvosP1xdwDHJLorAT/BaiLQmqVOEdRj0Gv6a8jwWkxje8TnzToOgJo28RHhOc5YhHOvhwrJGPp60RbyOfbbNRkAsSHNVab8pvQ8vbOssQ2SLs/EbFoZAHVjQ2LbeGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=i8nXoS8K; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="i8nXoS8K" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43P3BtjO017292; Thu, 25 Apr 2024 03:24:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=GDJttSaAJHCIVva3XnzqMpczfz0WpHXgk6knXs3cmB8=; b=i8 nXoS8KtjCgPZLJIsTfs0Xn5j94dtBGIMK8BOp6bL5iolmReU6MNzmDGDXjsKiUUL 4kIwAZYu1fq47zkjXSzrCWIYxBNhnEH5sztCr9gLPsVmurVn9Q6j274xCaBvFoo4 ZAKACmJ3ccS/UgSQVGvN7BXFlpppHhEvEzfw5Wdk5GGnTHgZGYwg3Cu/7+OSEc5q TQ0daLVdvkQf28imB3+VHJbt5oHqF3ouFG7FZ9MX1bLgyZS+sLp8WqKGBqlOPSe4 nY93p8KsSjOITmoW/yE2Mv2Urg9r86BlV7rOC7djT7YBeppLon2CmtaLRI6Nc3dA zqWsVwUcKXE1MZi4q0uw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xqenkg2ch-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 03:24:10 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43P3O8kF021777 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2024 03:24:08 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 24 Apr 2024 20:24:02 -0700 Message-ID: <708b5097-b41c-4c5b-9fe2-aaa578e8c6f1@quicinc.com> Date: Thu, 25 Apr 2024 11:23:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/4] arm64: dts: qcom: aim300: add AIM300 AIoT To: Dmitry Baryshkov CC: , , , , , , , , , , , , , Qiang Yu , Ziyue Zhang References: <20240424024508.3857602-1-quic_tengfan@quicinc.com> <20240424024508.3857602-5-quic_tengfan@quicinc.com> From: Tengfei Fan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 0mEXBxPJv1SxY1KQvAKqrkvVcgS3saxx X-Proofpoint-GUID: 0mEXBxPJv1SxY1KQvAKqrkvVcgS3saxx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_02,2024-04-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404250023 On 4/25/2024 7:50 AM, Dmitry Baryshkov wrote: > On Wed, 24 Apr 2024 at 05:46, Tengfei Fan wrote: >> >> Add AIM300 AIoT Carrier board DTS support, including usb, UART, PCIe, >> I2C functions support. >> Here is a diagram of AIM300 AIoT Carrie Board and SoM >> +--------------------------------------------------+ >> | AIM300 AIOT Carrier Board | >> | | >> | +-----------------+ | >> |power----->| Fixed regulator |---------+ | >> | +-----------------+ | | >> | | | >> | v VPH_PWR | >> | +----------------------------------------------+ | >> | | AIM300 SOM | | | >> | | |VPH_PWR | | >> | | v | | >> | | +-------+ +--------+ +------+ | | >> | | | UFS | | QCS8550| |PMIC | | | >> | | +-------+ +--------+ +------+ | | >> | | | | >> | +----------------------------------------------+ | >> | | >> | +----+ +------+ | >> | |USB | | UART | | >> | +----+ +------+ | >> +--------------------------------------------------+ >> >> Co-developed-by: Qiang Yu >> Signed-off-by: Qiang Yu >> Co-developed-by: Ziyue Zhang >> Signed-off-by: Ziyue Zhang >> Signed-off-by: Tengfei Fan >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../boot/dts/qcom/qcs8550-aim300-aiot.dts | 343 ++++++++++++++++++ >> 2 files changed, 344 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/qcs8550-aim300-aiot.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index f63abb43e9fe..c46c10d85697 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -96,6 +96,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-idp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qrb2210-rb1.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qrb4210-rb2.dtb >> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-aim300-aiot.dts b/arch/arm64/boot/dts/qcom/qcs8550-aim300-aiot.dts >> new file mode 100644 >> index 000000000000..146bf6ea9e6a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/qcs8550-aim300-aiot.dts >> @@ -0,0 +1,343 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include >> +#include "qcs8550-aim300.dtsi" >> +#include "pm8010.dtsi" >> +#include "pmr735d_a.dtsi" >> +#include "pmr735d_b.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. QCS8550 AIM300 AIOT"; >> + compatible = "qcom,qcs8550-aim300-aiot", "qcom,qcs8550-aim300", "qcom,qcs8550", >> + "qcom,sm8550"; >> + >> + aliases { >> + serial0 = &uart7; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + gpio-keys { >> + compatible = "gpio-keys"; >> + >> + pinctrl-0 = <&volume_up_n>; >> + pinctrl-names = "default"; >> + >> + key-volume-up { >> + label = "Volume Up"; >> + debounce-interval = <15>; >> + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; >> + linux,code = ; >> + linux,can-disable; >> + wakeup-source; >> + }; >> + }; >> + >> + pmic-glink { >> + compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + orientation-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>; >> + >> + connector@0 { >> + compatible = "usb-c-connector"; >> + reg = <0>; >> + power-role = "dual"; >> + data-role = "dual"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + pmic_glink_hs_in: endpoint { >> + remote-endpoint = <&usb_1_dwc3_hs>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + pmic_glink_ss_in: endpoint { >> + remote-endpoint = <&redriver_ss_out>; >> + }; >> + }; >> + >> + port@2 { >> + reg = <2>; >> + >> + pmic_glink_sbu: endpoint { >> + remote-endpoint = <&fsa4480_sbu_mux>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> + vph_pwr: regulator-vph-pwr { >> + compatible = "regulator-fixed"; >> + regulator-name = "vph_pwr"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> +}; >> + >> +&apps_rsc { >> + regulators-0 { >> + vdd-bob1-supply = <&vph_pwr>; >> + vdd-bob2-supply = <&vph_pwr>; >> + }; >> + >> + regulators-3 { >> + vdd-s4-supply = <&vph_pwr>; >> + vdd-s5-supply = <&vph_pwr>; >> + }; >> + >> + regulators-4 { >> + vdd-s4-supply = <&vph_pwr>; >> + }; >> + >> + regulators-5 { >> + vdd-s1-supply = <&vph_pwr>; >> + vdd-s2-supply = <&vph_pwr>; >> + vdd-s3-supply = <&vph_pwr>; >> + vdd-s4-supply = <&vph_pwr>; >> + vdd-s5-supply = <&vph_pwr>; >> + vdd-s6-supply = <&vph_pwr>; >> + }; >> +}; >> + >> +&i2c_hub_2 { >> + status = "okay"; >> + >> + typec-mux@42 { >> + compatible = "fcs,fsa4480"; >> + reg = <0x42>; >> + >> + vcc-supply = <&vreg_bob1>; >> + >> + mode-switch; >> + orientation-switch; >> + >> + port { >> + fsa4480_sbu_mux: endpoint { >> + remote-endpoint = <&pmic_glink_sbu>; >> + }; >> + }; >> + }; >> + >> + typec-retimer@1c { >> + compatible = "onnn,nb7vpq904m"; >> + reg = <0x1c>; >> + >> + vcc-supply = <&vreg_l15b_1p8>; >> + >> + orientation-switch; >> + retimer-switch; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + redriver_ss_out: endpoint { >> + remote-endpoint = <&pmic_glink_ss_in>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + redriver_ss_in: endpoint { >> + data-lanes = <3 2 1 0>; >> + remote-endpoint = <&usb_dp_qmpphy_out>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&mdss_dsi0 { >> + status = "okay"; >> + >> + panel@0 { >> + compatible = "visionox,vtdr6130"; >> + reg = <0>; >> + >> + pinctrl-0 = <&dsi_active>, <&te_active>; >> + pinctrl-1 = <&dsi_suspend>, <&te_suspend>; >> + pinctrl-names = "default", "sleep"; >> + >> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; >> + >> + vci-supply = <&vreg_l13b_3p0>; >> + vdd-supply = <&vreg_l11b_1p2>; >> + vddio-supply = <&vreg_l12b_1p8>; >> + >> + port { >> + panel0_in: endpoint { >> + remote-endpoint = <&mdss_dsi0_out>; >> + }; >> + }; >> + }; >> +}; >> + >> +&mdss_dsi0_out { >> + remote-endpoint = <&panel0_in>; >> + data-lanes = <0 1 2 3>; >> +}; >> + >> +&mdss_dsi0_phy { >> + status = "okay"; >> +}; >> + >> +&pcie0 { >> + pinctrl-0 = <&pcie0_default_state>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> +}; >> + >> +&pcie0_phy { >> + status = "okay"; >> +}; >> + >> +&pcie1 { >> + pinctrl-0 = <&pcie1_default_state>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> +}; >> + >> +&pcie1_phy { >> + status = "okay"; >> +}; >> + >> +&pm8550_gpios { >> + volume_up_n: volume-up-n-state { >> + pins = "gpio6"; >> + function = "normal"; >> + power-source = <1>; >> + bias-pull-up; >> + input-enable; >> + }; >> +}; >> + >> +&pon_pwrkey { >> + status = "okay"; >> +}; >> + >> +&pon_resin { >> + linux,code = ; >> + >> + status = "okay"; >> +}; >> + >> +&qupv3_id_0 { >> + status = "okay"; >> +}; >> + >> +&remoteproc_adsp { >> + firmware-name = "qcom/qcs8550/adsp.mbn", >> + "qcom/qcs8550/adsp_dtbs.elf"; >> + status = "okay"; >> +}; >> + >> +&remoteproc_cdsp { >> + firmware-name = "qcom/qcs8550/cdsp.mbn", >> + "qcom/qcs8550/cdsp_dtbs.elf"; >> + status = "okay"; >> +}; >> + >> +&swr1 { >> + status = "okay"; >> +}; >> + >> +&swr2 { >> + status = "okay"; >> +}; >> + >> +&tlmm { >> + gpio-reserved-ranges = <32 8>; >> + >> + dsi_active: dsi-active-state { >> + pins = "gpio133"; >> + function = "gpio"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + >> + dsi_suspend: dsi-suspend-state { >> + pins = "gpio133"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + te_active: te-active-state { >> + pins = "gpio86"; >> + function = "mdp_vsync"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + te_suspend: te-suspend-state { >> + pins = "gpio86"; >> + function = "mdp_vsync"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> +}; >> + >> +&uart7 { >> + status = "okay"; >> +}; >> + >> +&usb_1 { >> + status = "okay"; >> +}; >> + >> +&usb_1_dwc3 { >> + dr_mode = "otg"; > > OTG is default and can be dropped. OTG will be dropped. > >> + usb-role-switch; > > Please move to SoC dtsi and drop from board files. This will be moved to SoC dtsi. > >> +}; >> + >> +&usb_1_dwc3_hs { >> + remote-endpoint = <&pmic_glink_hs_in>; >> +}; >> + >> +&usb_1_dwc3_ss { >> + remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>; > > This too. This will be moved to SoC dtsi. > >> +}; >> + >> +&usb_1_hsphy { >> + status = "okay"; >> +}; >> + >> +&usb_dp_qmpphy { >> + orientation-switch; > > This too This will be moved to SoC dtsi. > >> + >> + status = "okay"; >> +}; >> + >> +&usb_dp_qmpphy_out { >> + remote-endpoint = <&redriver_ss_in>; >> +}; >> + >> +&usb_dp_qmpphy_usb_ss_in { >> + remote-endpoint = <&usb_1_dwc3_ss>; > > And this. This will be moved to SoC dtsi. > >> +}; >> -- >> 2.25.1 >> > > -- Thx and BRs, Tengfei Fan