From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcDZKF4 (ORCPT ); Tue, 26 Apr 2016 06:05:56 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55459 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbcDZKFy (ORCPT ); Tue, 26 Apr 2016 06:05:54 -0400 From: Arnd Bergmann To: Christoph Hellwig Cc: James Bottomley , "Martin K. Petersen" , Josh Poimboeuf , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Denys Vlasenko , Thomas Graf , Peter Zijlstra , David Rientjes , Andrew Morton , jamborm@gcc.gnu.org, Ingo Molnar , Himanshu Madhani , qla2xxx-upstream@qlogic.com Subject: Re: [PATCH] scsi: fc: force inlining of wwn conversion functions Date: Tue, 26 Apr 2016 12:05:01 +0200 Message-ID: <7383310.fFF78fn4MN@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160426083516.GC364@infradead.org> References: <20160419085221.GA29087@gmail.com> <5249561.9VpAPLD61M@wuerfel> <20160426083516.GC364@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:q8wulRcMd7YUQsv4T612m7h8+3Mpqla/4wfSw8oPfpegIqYj7XX wMmNx+6xWx0eCZKzRIgaAhtgmVY3Lk82iqNSh2OvfDKvviIb33hHBBWKgN+nw6X2Mcv1hOC sJfJGsDV3LF+v6+DMPfsUUVg3t/lMD0Xj5W4rcFjKNkNZR4rrpUOctuyHG01oUbdA18o+t7 PJa5csNVb8W2EjwShX8qw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GXj5lV5VVd4=:SqnjDCW9u7GIQ45ExLA+P4 JpPx3x0XAc8pbkq6rSIH+ejRi7K4Ptut/fk2q1ixDo92+LCOipZ3zJ/U3plcIWXmirhnPH2uo TFTY0ekEQ4808mLLCWzIEJciiggKpIu5Nz82MBZl39PgPaFyo4roCEPAbhLHV7byYK7d4reh7 cMOYrG2sJ2Yk4BiMOpCerg5cX3jOpBSQnSbN7FH6N3r8o0eHJ55LlTDLKoUU9zrSuicKW5H5l c0W6ke1D2hZ6Gfz30/x/KSLxXrTjsanBQxV2g1fKctvMrscB+BZK3AoQC21tcH20Lsfpa2GWj Ka9yi/hEisrIgM5LnwKSasNu3B4D9KUOzn3mOkjywX9X/JdXi14BspTsAgtHAU6wjeJna67aO Iy//b8rJGUrrxqp+wX+zGrjOU0wiAneOKvMy2VwUu+AO7/sCVzUTPGw5fj3f3/BFZTo70Hh9Z MX4mUv499zFV27aZ3xOhSLCPJNX4FXactjfmG8/J3GZ/SIwfnO0TF4Ju3TPVjs1mpi+wbZNkP o15vOSSbYglbn/2Vt295nq8dvckKQgc6CQYr4YvNYHwmFjetzXtQAteT435y0MFDAIlJeF1WR NPznJQfOqv4nVNtbKdbVAKIkRcYt1TUpbw2h8uy9r+IP4mrB1S03u6rXGmlfXRSZOi+c/AjCW dgVAc715GP8vuBnoNIVuLfEQtnEvKOGWZrOXbmmBo9xnnTK0ltN5WrU/EPNH87lp+Vp3bBaJQ TMHDvECYo+x/OiJI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 26 April 2016 01:35:16 Christoph Hellwig wrote: > On Tue, Apr 26, 2016 at 09:22:46AM +0200, Arnd Bergmann wrote: > > > Agree, plus, as I've said before, we have 3-4 weeks before we go final, > > > so we still have some time before a decision has to be made. It looks > > > like the gcc people already have a patch for the compiler, so the > > > distributions could just push that out through channels. > > > > I don't think we can realistically blacklist gcc-4.9.{0,1,2,3}, > > gcc-5.{0,1,2,3}.* and gcc-6.0 and require everyone to upgrade to compilers > > that have not been released yet in order to build a linux-4.6 kernel. > > Agreed. What about just removing the wrappers? They seem fairly > pointless to start with. I think at this point it's mainly a question of whether we want such a big (however trivial) patch in v4.6. We can certainly do that for 4.7, but as a fixup for the existing problem, either the __always_inline hack or using a macro should be sufficient: diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h index bf66ea6bed2b..51a98b182a67 100644 --- a/include/scsi/scsi_transport_fc.h +++ b/include/scsi/scsi_transport_fc.h @@ -796,15 +796,8 @@ fc_remote_port_chkready(struct fc_rport *rport) return result; } -static inline u64 wwn_to_u64(u8 *wwn) -{ - return get_unaligned_be64(wwn); -} - -static inline void u64_to_wwn(u64 inm, u8 *wwn) -{ - put_unaligned_be64(inm, wwn); -} +#define wwn_to_u64(wwn) get_unaligned_be64(wwn) +#define u64_to_wwn(inm, wwn) put_unaligned_be64(inm, wwn) /** * fc_vport_set_state() - called to set a vport's state. Saves the old state, Arnd