From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()
Date: Wed, 14 Apr 2021 20:05:59 +0200 [thread overview]
Message-ID: <7427098.3VjF5iJQtU@linux.local> (raw)
In-Reply-To: <YHcs70RdhaBBZv0i@kroah.com>
On Wednesday, April 14, 2021 7:57:03 PM CEST Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote:
> > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco
wrote:
> > > > Removed useless led_blink_hdl() prototype and definition. In
> > > > wlancmds[]
> > > > the slot #60 is now set to NULL using the macro
> > > > GEN_MLME_EXT_HANDLER. This change has not unwanted side effects
> > > > because the code in rtw_cmd.c checks if the function pointer is
> > > > valid before using it.
> > > >
> > > > Reported-by: Julia Lawall <julia.lawall@inria.fr>
> > > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > ---
> > > >
> > > > Changes since v1: Corrected a bad solution to this issue that made
> > > > use of an unnecessary dummy function.
> > > >
> > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
> > > > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 -
> > > > 3 files changed, 1 insertion(+), 11 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > b/drivers/staging/rtl8723bs/core/rtw_cmd.c index
> > > > 0297fbad7bce..f82dbd4f4c3d 100644
> > > > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > > > @@ -150,7 +150,7 @@ static struct cmd_hdl wlancmds[] = {
> > > >
> > > > GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/
> > > > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param),
> > > > set_chplan_hdl) /*59*/> > >
> > > > - GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param),
> > > > led_blink_hdl) /*60*/ + GEN_MLME_EXT_HANDLER(0, NULL) /*60*/
> > >
> > > Better, but you really do not need to keep this here, right? Remove
> > > the
> > > "led blink command" entirely, you didn't do that here.
> >
> > No, this is right. We have to put a NULL function pointer in the array
> > or the indexing will be off. But Fabio is correct that the struct
> > type should be removed.
>
> The indexing can be off, just remove the other place where the "command"
> is in the index and all is good as rebuilding will fix it. These are
> not external "values" we have to keep stable.
>
> This has been done for other drivers exactly like this, there are loads
> of "odd" commands in there that should not be.
>
> thanks,
>
> greg k-h
I'm not sure if this task is so close related to deserve a v3 or if I
should make a new v1 patch with a different "Subject".
Thanks,
Fabio
next prev parent reply other threads:[~2021-04-14 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 16:26 [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl() Fabio M. De Francesco
2021-04-14 16:46 ` Fabio Aiuto
2021-04-14 17:00 ` Greg Kroah-Hartman
2021-04-14 17:48 ` Dan Carpenter
2021-04-14 17:57 ` Greg Kroah-Hartman
2021-04-14 18:05 ` Fabio M. De Francesco [this message]
2021-04-14 18:24 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7427098.3VjF5iJQtU@linux.local \
--to=fmdefrancesco@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).