From: Johannes Berg <johannes@sipsolutions.net>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: "Alvin Šipraga" <alvin@pqrs.dk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next] wifi: nl80211: emit CMD_START_AP on multicast group when an AP is started
Date: Tue, 24 Jan 2023 10:26:41 +0100 [thread overview]
Message-ID: <758384602b93da0f242ee5d82847a1b4ab102b91.camel@sipsolutions.net> (raw)
In-Reply-To: <20230121130717.l5ynezk4rug7fypb@bang-olufsen.dk>
Hi,
> > Seems like you should include the link ID or something?
>
> Thanks for your review, you are quite right. I didn't give much thought
> to MLO as I am not too familiar with it. Is something like the below
> what you are looking for?
Yes, that looks good.
> Speaking of which: I drew inspiration from nl80211_send_ap_stopped()
> which see also doesn't include the link ID. Would you like me to include
> a second patch in v2 which adds the link ID to that function along the
> same lines?
Maybe have that as a separate patch, but yeah, good idea - thanks for
looking!
johannes
prev parent reply other threads:[~2023-01-24 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 15:28 [PATCH next] wifi: nl80211: emit CMD_START_AP on multicast group when an AP is started Alvin Šipraga
2023-01-18 16:26 ` Johannes Berg
2023-01-21 13:07 ` Alvin Šipraga
2023-01-24 9:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=758384602b93da0f242ee5d82847a1b4ab102b91.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ALSI@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).