From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB54C433B4 for ; Thu, 20 May 2021 20:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 145206109F for ; Thu, 20 May 2021 20:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237691AbhETU3I (ORCPT ); Thu, 20 May 2021 16:29:08 -0400 Received: from ms.lwn.net ([45.79.88.28]:60702 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236963AbhETU3H (ORCPT ); Thu, 20 May 2021 16:29:07 -0400 Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 814E72F3; Thu, 20 May 2021 20:27:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 814E72F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1621542465; bh=4Sb890MJb2ftT0eWtK0c6D8gcH4gbMVh+6xP0bEVTBU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iqmdk/F0zXlaOzi2qIfonlCtVp7Uo3ZYdslx8Oxhc8VWiicgjKQm4xQE1ZRDUuUzI tFtqZDz18WQRoqB6pV+j9C4tJkmEaK9kVwDm+SLWLA3PjJ3IPRTqwUpd8qZ/qIQZ8G VEUVtJGqoT7zTxMCd/gvZDTBKOzQZY3aJEWFuo6TxL8hlTCNH65N3o9EQVFDrY+byu YEjZRkEHxe+0534Qx9S083tTbZK/RctTIcoTTVN641pLiN+a44A7oEwE/a//+TFtQE EN8Dvcj8CqDReMukj2VRfwjQV2RZRQS45gjjYvicT7reR3XaMRlWnrIYe1xHLl3cf2 nSGYaovzR4T8w== From: Jonathan Corbet To: Andrew Jeffery , linux-doc@vger.kernel.org Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, joe@perches.com, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Jiri Slaby Subject: Re: [PATCH v2] Documentation: checkpatch: Tweak BIT() macro include In-Reply-To: <20210520093949.511471-1-andrew@aj.id.au> References: <20210520093949.511471-1-andrew@aj.id.au> Date: Thu, 20 May 2021 14:27:45 -0600 Message-ID: <8735uhnoam.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Jeffery writes: > While include/linux/bitops.h brings in the BIT() macro, it was moved to > include/linux/bits.h in commit 8bd9cb51daac ("locking/atomics, asm-generic: > Move some macros from to a new file"). > > Since that commit BIT() has moved again into include/vdso/bits.h via > commit 3945ff37d2f4 ("linux/bits.h: Extract common header for vDSO"). > > I think the move to the vDSO header can be considered an implementation > detail, so for now update the checkpatch documentation to recommend use > of include/linux/bits.h. > > Cc: Jiri Slaby > Acked-by: Jiri Slaby > Signed-off-by: Andrew Jeffery > --- > Documentation/dev-tools/checkpatch.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst > index 51fed1bd72ec..59fcc9f627ea 100644 > --- a/Documentation/dev-tools/checkpatch.rst > +++ b/Documentation/dev-tools/checkpatch.rst > @@ -472,7 +472,7 @@ Macros, Attributes and Symbols > > **BIT_MACRO** > Defines like: 1 << could be BIT(digit). > - The BIT() macro is defined in include/linux/bitops.h:: > + The BIT() macro is defined via include/linux/bits.h:: Applied, thanks. jon