From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89ADDC7EE25 for ; Fri, 9 Jun 2023 15:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240670AbjFIP1E (ORCPT ); Fri, 9 Jun 2023 11:27:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241869AbjFIP0m (ORCPT ); Fri, 9 Jun 2023 11:26:42 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D58A3C11 for ; Fri, 9 Jun 2023 08:26:24 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686324382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=97eIlmVHHiXKUyciMmtc/hv+PsyVp2v+mcQ37Qjk6dU=; b=e+Iiazwjdi0sSxQOkSd63xWdxVQpwfjV8PlWhPv5HyrT7kfAquJkI8QAFEI7ZU+bv9Jfjq k128Ic2mKAGIbPBAl9jAhGdHuOnW70t/711Y25HHD4Jz6AuRgOW/v13To1nVq50f3scVVL F8zCFCM8w+d0Az32OpuNuWudCDJbi/oFzh+WZDxjtelrYD7GtTTJiR/ZlfwO49NjRI3u/M Nn0crU6QRv+LrPq0OnJdtt7nJ5U7ue/lcC2xKzyCHDiPH/KHEhjm1PeSBsJtmqCpEx6DoB Ewf8MM4b6vshkW/XvNaU5X0NEwIQ8IfMUFziyZFXuUbyZRcJZAPCSZZblWFFuA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686324382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=97eIlmVHHiXKUyciMmtc/hv+PsyVp2v+mcQ37Qjk6dU=; b=1GDIMJG5h0PhIqh4dL5/8yYRO5/HJLJPSR5lFrxvRuupX0B8QfLyZYdkj9lJDoFoQKJQKW 1V52IvTSK0YWo2Bg== To: Nikolay Borisov , x86@kernel.org Cc: linux-kernel@vger.kernel.org, mhocko@suse.com, jslaby@suse.cz, Nikolay Borisov Subject: Re: [PATCH v2 4/4] x86: Disable laoding 32bit processes if ia32_disabled is true In-Reply-To: <20230609111311.4110901-5-nik.borisov@suse.com> References: <20230609111311.4110901-1-nik.borisov@suse.com> <20230609111311.4110901-5-nik.borisov@suse.com> Date: Fri, 09 Jun 2023 17:26:21 +0200 Message-ID: <87bkhoirmq.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09 2023 at 14:13, Nikolay Borisov wrote: > diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h > index 18fd06f7936a..0fa49388ff16 100644 > --- a/arch/x86/include/asm/elf.h > +++ b/arch/x86/include/asm/elf.h > @@ -148,9 +148,16 @@ do { \ > #define elf_check_arch(x) \ > ((x)->e_machine == EM_X86_64) > > +#ifdef CONFIG_IA32_EMULATION > +extern bool ia32_disabled; > #define compat_elf_check_arch(x) \ 1) Your keyboard clearly has a broken newline key. 2) Why is there still a duplicated declaration? 3) This #ifdeffery is not needed if this is done right. Thanks, tglx