From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57682C7EE2E for ; Sat, 10 Jun 2023 23:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232354AbjFJXT0 (ORCPT ); Sat, 10 Jun 2023 19:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbjFJXTY (ORCPT ); Sat, 10 Jun 2023 19:19:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DED35B8 for ; Sat, 10 Jun 2023 16:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686439112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D8heU8KT8N66egWqP5syvdzwEBmAm1JS5VTvHxIRqqk=; b=HlP9ANwkOmYItpdsM128+WC1bF6W90rvvpzPgtPws1VzKTSh80DvFN91lup06ZOt0o4j9J 1KxR9lTWT+hOZOGdhcKggg7XuQi5DeAR3ySqhgQVG+1GCvLE9+ALBxRa1szF3TZQaefE97 o49w0pNXYNDQpoz3tqrZL8q88o+b6bY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-xojpT15ZPaaS-xnuu0rn5w-1; Sat, 10 Jun 2023 19:18:31 -0400 X-MC-Unique: xojpT15ZPaaS-xnuu0rn5w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-30e55b42af1so1731924f8f.3 for ; Sat, 10 Jun 2023 16:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686439110; x=1689031110; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D8heU8KT8N66egWqP5syvdzwEBmAm1JS5VTvHxIRqqk=; b=e4kto/dRfzZ7LZHM9FokRWSBWv0cCdWSlGh6FB5jsh6u/EC49p6ybroEHry+jNK9eX siKlF0bBmsTw54OMzgEL7IO4Wl+vxEJtSXbtL9u8IRdzPuKYBKW0ytQDSDh38dQSvJ9V QtiPb8fDSxZjnPaBN4p0FMG98DPTyI1yGPqvvroRFx4sJT7YAk47TyOi7JNMdZ6NfRs8 YF2Ah4irn84k92YOcIi2b8vPgAcl9vnZNtD/+Smt5Yc4sdAhzMnoBbRTj4HApeciPUik +LsiIEdQLBZsz+BSMIYI16ydozLl0XbXK1AHPJlPpYb098iEzkPbDMO9ocKFI3sXQaIl f7hA== X-Gm-Message-State: AC+VfDzUk9FRpPpLrMK9RAcFbIhMG3GrcjVjW37Ha44Tm/xjDYvMXtOr trs3qCVSBr/PdjsPjdy3pXk7xzhKXHEaRmx0D7PBU0xDtoGdn/pLC7b5PObPPCGCSpLbOgwixpR GaA9kZr5Z+Vf5ygED9x5FdeFP X-Received: by 2002:a5d:4983:0:b0:30a:dfb4:e300 with SMTP id r3-20020a5d4983000000b0030adfb4e300mr1844979wrq.28.1686439110018; Sat, 10 Jun 2023 16:18:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jG5fprO8u5UBAEpGm2MDfpLiBPONYgvdFhUff4goghNW/o4Wo5d0iU8B2i0qViPYwH7b8Ow== X-Received: by 2002:a5d:4983:0:b0:30a:dfb4:e300 with SMTP id r3-20020a5d4983000000b0030adfb4e300mr1844970wrq.28.1686439109700; Sat, 10 Jun 2023 16:18:29 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id n6-20020a7bcbc6000000b003f6f6a6e769sm6807965wmi.17.2023.06.10.16.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 16:18:29 -0700 (PDT) From: Javier Martinez Canillas To: Conor Dooley Cc: devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , Geert Uytterhoeven , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values In-Reply-To: <20230610-unused-engaged-c1f4119cff08@spud> References: <20230609170941.1150941-1-javierm@redhat.com> <20230609170941.1150941-3-javierm@redhat.com> <20230610-opposite-quality-81d4a1561c88@spud> <87r0qj19zs.fsf@minerva.mail-host-address-is-not-set> <20230610-unused-engaged-c1f4119cff08@spud> Date: Sun, 11 Jun 2023 01:18:28 +0200 Message-ID: <87jzwa29ff.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Conor Dooley writes: > On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: >> Conor Dooley writes: >> >> > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: >> >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 >> >> anymore. Instead is set to a width and height that's controller dependent. >> > >> > Did that change to the driver not break backwards compatibility with >> > existing devicetrees that relied on the default values to get 96x16? >> > >> >> It would but I don't think it is an issue in pratice. Most users of these >> panels use one of the multiple libraries on top of the spidev interface. >> >> For the small userbase that don't, I believe that they will use the rpif >> kernel and ssd1306-overlay.dtbo DTB overlay, which defaults to width=128 >> and height=64 [1]. So those users will have to explicitly set a width and >> height for a 96x16 panel anyways. >> >> The intersection of users that have a 96x16 panel, assumed that default >> and consider the DTB a stable ABI, and only update their kernel but not >> the DTB should be very small IMO. > > It's the adding of new defaults that makes it a bit messier, since you > can't even revert without potentially breaking a newer user. I'd be more > inclined to require the properties, rather change their defaults in the > binding, lest there are people relying on them. I think that's OK, the old drivers/video/fbdev/ssd1307fb.c fbdev driver still has the old behaviour so it will only be a problem for users that want to move to the new ssd130x driver as well. By looking at the git log history, the 96x16 resolution was chosen when the driver was merged because Maxime tested it on a CFA10036 board [1] that has a 96x16 panel that uses an SSD1307 controller. But as mentioned, that chip can drive up to 128x39 pixels so the maximum makes more sense as default to me. [1]: https://www.crystalfontz.com/product/cfa10036 > If you and the other knowledgeable folk in the area really do know such > users do not exist then I suppose it is fine to do. I believe is fine, since as explained above that change was only done in the ssd130x DRM driver, not the ssd1307fb fbdev driver whose default is still 96x16. Both drivers share the same DT binding scheme, I was asked to do that to make it as much backward compatible as possible with the old fbdev driver. But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings from the DRM driver and only match against the new "solomon,ssd130?-i2c" compatible strings. And add a different DT binding schema for the ssd130x driver, if that would mean being able to fix things like the one mentioned in this patch. In my opinion, trying to always make the drivers backward compatible with old DTBs only makes the drivers code more complicated for unclear benefit. Usually this just ends being code that is neither used nor tested. Because in practice most people update the DTBs and kernels, instead of trying to make the DTB a stable ABI like firmware. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat