From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jikos@kernel.org>
Cc: Jessica Yu <jeyu@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Vojtech Pavlik <vojtech@suse.com>,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] livepatch/module: remove livepatch module notifier
Date: Mon, 29 Feb 2016 11:00:09 +1030 [thread overview]
Message-ID: <87lh64e4tq.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1602101115420.22727@cbobk.fhfr.pm>
Jiri Kosina <jikos@kernel.org> writes:
> On Wed, 10 Feb 2016, Rusty Russell wrote:
>
>> > Remove the livepatch module notifier in favor of directly enabling and
>> > disabling patches to modules in the module loader. Hard-coding the
>> > function calls ensures that ftrace_module_enable() is run before
>> > klp_module_coming() during module load, and that klp_module_going() is
>> > run before ftrace_release_mod() during module unload. This way, ftrace
>> > and livepatch code is run in the correct order during the module
>> > load/unload sequence without dependence on the module notifier call chain.
>> >
>> > This fixes a notifier ordering issue in which the ftrace module notifier
>> > (and hence ftrace_module_enable()) for coming modules was being called
>> > after klp_module_notify(), which caused livepatch modules to initialize
>> > incorrectly.
>>
>> Without a Fixes: line, it's not absolutely clear whether this needs
>> CC:stable, needs to go to Linus now, or can wait for the next merge
>> window.
>>
>> I *think* you want all four merged this merge window, and 3 and 4 are
>> required to fix a regression introduced since 4.4...
>
> Your understanding is correct; #3 and #4 are needed to fix a 4.4
> regression. It makes sense for the whole lot go to together, but for #1
> and #2 I absolutely need your Ack before I take it to my tree, as I don't
> want to be merging this behind your back.
>
> Once you Ack #1 and #2, I plan to take this to Linus immediately so that
> we avoid doing these changes as very last minute.
Sorry Jiri, I am on paternity leave. Am happy with all these patches;
please use your best judgement:
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
next prev parent reply other threads:[~2016-03-01 2:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 4:50 [PATCH v4 0/4] Fix ordering of ftrace/livepatch calls on module load and unload Jessica Yu
2016-02-09 4:50 ` [PATCH v4 1/4] modules: split part of complete_formation() into prepare_coming_module() Jessica Yu
2016-02-09 15:41 ` Josh Poimboeuf
2016-02-10 10:13 ` Miroslav Benes
2016-02-10 12:16 ` Petr Mladek
2016-02-09 4:50 ` [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING before going notifiers are called Jessica Yu
2016-02-09 15:45 ` Josh Poimboeuf
2016-02-10 10:20 ` Miroslav Benes
2016-02-10 12:37 ` Petr Mladek
2016-02-09 4:50 ` [PATCH v4 3/4] ftrace/module: remove ftrace module notifier Jessica Yu
2016-02-09 15:45 ` Josh Poimboeuf
2016-02-10 10:27 ` Miroslav Benes
2016-02-09 4:50 ` [PATCH v4 4/4] livepatch/module: remove livepatch " Jessica Yu
2016-02-09 15:45 ` Josh Poimboeuf
2016-02-09 23:43 ` Rusty Russell
2016-02-10 10:18 ` Jiri Kosina
2016-02-14 22:59 ` Jiri Kosina
2016-02-15 23:27 ` Josh Poimboeuf
2016-02-15 23:42 ` Jiri Kosina
2016-02-16 0:48 ` Jessica Yu
2016-02-16 8:41 ` Miroslav Benes
2016-02-16 19:51 ` Jessica Yu
2016-03-29 2:03 ` [PATCH v4 4/4] " Steven Rostedt
2016-02-29 0:30 ` Rusty Russell [this message]
2016-03-01 3:00 ` Jessica Yu
2016-02-10 10:34 ` [PATCH v4 4/4] " Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh64e4tq.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).