From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9200CC433B4 for ; Wed, 14 Apr 2021 17:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F0C761166 for ; Wed, 14 Apr 2021 17:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349570AbhDNRR1 (ORCPT ); Wed, 14 Apr 2021 13:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234029AbhDNRR0 (ORCPT ); Wed, 14 Apr 2021 13:17:26 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8715C061574 for ; Wed, 14 Apr 2021 10:17:04 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 18so24658052edx.3 for ; Wed, 14 Apr 2021 10:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adirat-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=rFkkjxqHpWb5oS2G5iwZaP+zKzf4ZbCevn2f+ZXYmBQ=; b=XDPQzlWAmTGGDU0UUms3P6TvEyasewv9bVvRbyQsLQllL6bIh+ShaUDY3kLUc+ANmV kKdJZnhuZez1381X4UWFyINleqoxjjUhOBTN5cncba0mz/disFhLJk/exy/ZwCYCUZ3x JddJAdlkp/RwxxuNkIVzKITJaQOxOLDK7YIalTx6qPnyapvomvN1fsC76VNaZkZv8ndt YEDYbpYSiWdqIPRK9R5l1/YNi6GCDz6i4Pkm6xBfneHtNAfmIRQNv417yLx3IBz2H783 5i/kdnMNw3IiDrsHP347RV7IowGyq6bExbb7VubQL3H7lN/CXYpDS4bzySMO+3nLrNVf N3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rFkkjxqHpWb5oS2G5iwZaP+zKzf4ZbCevn2f+ZXYmBQ=; b=R1GylovKeosYAE8sJ7VBMik4LqJJImCdCHJkf2rGqY5cUlILjT57MzPAUIWy5QVaY3 Wg98p1rT0bSukz9uQ7w7HIUK36QM/445mi9rb1PCNxDFDlZwDkSWcAFIoeyF4OsJASyY kgFIufWjH6xvPVg05rMCShl5EKeLshcz4BcVEPENpguh7lX5m6913MYvUkQ3RX10ofGf pCX8n3NrEZ9i1LEwJt8e0trYbXDG5YxLXG640wSkgu0YvgKTJJcl6xCTGjhrvrQ6v/fa nejSXDvzEPpjGILQuW/KuzXaQsMvwef79pcP85o0BKHI1QOyXsWiLzqzb+ZalP1wAOQ0 Fijg== X-Gm-Message-State: AOAM533qfGJfcquJl07sOF5bKocx/FNSuBPauerCi6roocbAw9J7qTAx U7KHuGVv5c7ukR8SZwU9PSW1zJxCTwdsGEitfNs= X-Google-Smtp-Source: ABdhPJxPS4Z3wTzfaWJwh+M5g6HZt1gMnX7j4nwwg8Rteb6I1kI1rWraEiYgKObVNIiY4j/Exqhijw== X-Received: by 2002:aa7:d341:: with SMTP id m1mr41865073edr.120.1618420623380; Wed, 14 Apr 2021 10:17:03 -0700 (PDT) Received: from ryzen9 ([79.119.97.29]) by smtp.gmail.com with ESMTPSA id g25sm141343edp.95.2021.04.14.10.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 10:17:02 -0700 (PDT) From: Ioan-Adrian Ratiu To: Salvatore Bonaccorso , Alessandro Grassi , 986561@bugs.debian.org, Benjamin Tissoires , Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Bug#986561: linux: Regression in drivers/hid/hid-dr.c causing horizontal D-pad to malfunction on SNES joystick In-Reply-To: References: <161779964431.889220.2857033195611862828.reportbug@malacoda> Date: Wed, 14 Apr 2021 20:17:01 +0300 Message-ID: <87o8eg946q.fsf@ryzen9.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 14 Apr 2021, Salvatore Bonaccorso wrote: > Hi Ioan-Adrian, > > On Wed, Apr 07, 2021 at 02:47:24PM +0200, Alessandro Grassi > wrote: >> Source: linux Severity: normal Tags: upstream X-Debbugs-Cc: >> alessandro@aggro.it Greetings, I am encountering the issue >> described in this thread[1], using a gamepad identified as >> "DragonRise" with USB ID 0079:0011. The joypad works as >> intended except for the D-pad: up and down are detected in >> jstest (though misinterpreted: the input graph shows the points >> in the left up/down corners instead of the center), the left >> and right buttons are completely ignored. Running >> 'input-events' shows events 0/127 and 255/127 on up and down >> respectively, nothing at all on left and right. I was able to >> identify that the misbehaviour was caused by this commit[2] on >> the kernel source tree. To determine this I have rebuilt the >> Debian kernel using hid-dr.c from the previous commit[3] and >> loaded hid-dr.ko manually, with which the gamepad worked as >> intended. I have replaced the file again with the one from the >> breaking commit iself ([2]) and the behaviour was again broken. >> Furthermore, to confirm that that was the breaking commit, I >> have commented line 315 (the input mapping one in the struct) >> from the current Debian source tree and rebuilt it, the joypad >> works as it should. Regards, Alessandro [1]: >> https://retropie.org.uk/forum/topic/25657/controler-issue-no-left-and-right-not-working-at-all >> [2]: >> https://github.com/torvalds/linux/commit/e15944099870f374ca7efc62f98cf23ba272ef43 >> [3]: >> https://github.com/torvalds/linux/commit/313726cad3b68039c8e4dcad5a2840a0d375678c > > A user in Debian reported that e15944099870 ("HID: hid-dr: add > input mapping for axis selection") introduced a regression, > described above. > > Does this ring some bell to you? Unfortunately no and I do not have the HW to test anymore. It is possible that change introduced a regression on newer "DragonRise" gamepads and maybe that mapping logic needs to be a bit more complex, depending on the HW differences. Sorry I can't be more helpful, Adrian > > Regards, > Salvatore