From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <frederic@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Subject: Re: [PATCH] sh: remove unused variable
Date: Mon, 10 May 2021 22:56:21 +0200 [thread overview]
Message-ID: <87sg2ugvey.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <c4ec09f0-8742-06ba-a213-063c40d2f98a@gmail.com>
On Mon, May 10 2021 at 22:11, Eric Dumazet wrote:
> On 4/14/21 7:05 PM, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> Removes this annoying warning:
>>
>> arch/sh/kernel/traps.c: In function ‘nmi_trap_handler’:
>> arch/sh/kernel/traps.c:183:15: warning: unused variable ‘cpu’ [-Wunused-variable]
>> 183 | unsigned int cpu = smp_processor_id();
>>
>> Fixes: fe3f1d5d7cd3 ("sh: Get rid of nmi_count()")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Frederic Weisbecker <frederic@kernel.org>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> ---
>> arch/sh/kernel/traps.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/sh/kernel/traps.c b/arch/sh/kernel/traps.c
>> index f5beecdac69382f2d719fa33d50b9d58e22f6ff8..e76b221570999776e3bc9276d6b2fd60b9132e94 100644
>> --- a/arch/sh/kernel/traps.c
>> +++ b/arch/sh/kernel/traps.c
>> @@ -180,7 +180,6 @@ static inline void arch_ftrace_nmi_exit(void) { }
>>
>> BUILD_TRAP_HANDLER(nmi)
>> {
>> - unsigned int cpu = smp_processor_id();
>> TRAP_HANDLER_DECL;
>>
>> arch_ftrace_nmi_enter();
>>
>
> Is there anything wrong with this patch ?
No. I was expecting that it gets picked up by sh folks. Let me take care
of it as I introduced that issue after all.
Thanks,
tglx
next prev parent reply other threads:[~2021-05-10 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 17:05 [PATCH] sh: remove unused variable Eric Dumazet
2021-05-10 20:11 ` Eric Dumazet
2021-05-10 20:56 ` Thomas Gleixner [this message]
2021-05-10 21:26 ` [tip: irq/urgent] sh: Remove " tip-bot2 for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg2ugvey.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dalias@libc.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).