From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9839FC433B4 for ; Wed, 14 Apr 2021 15:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79663611C9 for ; Wed, 14 Apr 2021 15:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352413AbhDNPxA (ORCPT ); Wed, 14 Apr 2021 11:53:00 -0400 Received: from mga06.intel.com ([134.134.136.31]:57417 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352431AbhDNPvK (ORCPT ); Wed, 14 Apr 2021 11:51:10 -0400 IronPort-SDR: wsKNU2pZUHE6XHGSr2aqnXbf4tQ7ZGn9xNRe/tUaPy2rIsAsyS+pc/T2E7WfnOz+qJ3aEWER+H E9vW7RgxNV6w== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="255987397" X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="255987397" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 08:50:46 -0700 IronPort-SDR: sGar3ZOMlBav4B9kq51Bfw5J0U8JPuqB8kFSdU8f74X7CDePN8jUeLeHUzLU5NIXuPAlnWH1bn dAbXS77+5xOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="382400250" Received: from um.fi.intel.com (HELO um) ([10.237.72.62]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2021 08:50:43 -0700 From: Alexander Shishkin To: Adrian Hunter , Peter Zijlstra , Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa , Mathieu Poirier , alexander.shishkin@linux.intel.com Subject: Re: [PATCH 2/2] perf intel-pt: Use aux_watermark In-Reply-To: References: <20210408153159.81880-1-alexander.shishkin@linux.intel.com> <20210408153159.81880-3-alexander.shishkin@linux.intel.com> Date: Wed, 14 Apr 2021 18:50:42 +0300 Message-ID: <87wnt4g90t.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adrian Hunter writes: > On 8/04/21 6:31 pm, Alexander Shishkin wrote: >> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c >> index a6420c647959..d00707faf547 100644 >> --- a/tools/perf/arch/x86/util/intel-pt.c >> +++ b/tools/perf/arch/x86/util/intel-pt.c >> @@ -776,6 +776,10 @@ static int intel_pt_recording_options(struct auxtrace_record *itr, >> } >> } >> >> + if (opts->full_auxtrace) >> + intel_pt_evsel->core.attr.aux_watermark = >> + opts->auxtrace_mmap_pages / 4 * page_size; >> + > > I would be explicit about the mode and put "/ 4" at the end > for the case auxtrace_mmap_pages is not a multiple of 4 (e.g. 2). > i.e. > > if (!opts->auxtrace_snapshot_mode && !opts->auxtrace_sample_mode) { > u32 aux_watermark = opts->auxtrace_mmap_pages * page_size / 4; > > intel_pt_evsel->core.attr.aux_watermark = aux_watermark; > } Thank you! I'll do exactly that. Regards, -- Alex