From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752719AbcBEJuq (ORCPT ); Fri, 5 Feb 2016 04:50:46 -0500 Received: from mail2.elkosia.lv ([85.15.200.133]:33215 "EHLO prod.silodev.eu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752700AbcBEJu2 (ORCPT ); Fri, 5 Feb 2016 04:50:28 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 05 Feb 2016 11:49:47 +0200 From: Madars Vitolins To: Andrew Morton Cc: Jason Baron , torvalds@linux-foundation.org, mtk.manpages@gmail.com, mingo@kernel.org, peterz@infradead.org, viro@ftp.linux.org.uk, normalperson@yhbt.net, corbet@lwn.net, luto@amacapital.net, hagen@jauu.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT In-Reply-To: <20160204145952.53f536f5d4cdef96844104b7@linux-foundation.org> References: <1454600344-23655-1-git-send-email-jbaron@akamai.com> <00ac7df620d4d0500b18af4a30034815@silodev.com> <20160204145952.53f536f5d4cdef96844104b7@linux-foundation.org> Message-ID: <994cbd84457a4986e03ad0c4369600fa@silodev.com> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton @ 2016-02-05 00:59 rakstīja: > On Thu, 04 Feb 2016 23:44:05 +0200 Madars Vitolins > wrote: > >> Hi Jason, >> >> >> Just run off the original tests with this patch (eventpoll.c from >> 4.5-rc2 + patch bellow). Got the same good results, no regression. >> >> $ time ./bankcl >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 1359856158.04 USD >> Account balance is: 101528948.40 USD >> >> real 0m41.826s >> user 0m29.513s >> sys 0m6.490s >> >> >> Test case: >> https://mvitolin.wordpress.com/2015/12/05/endurox-testing-epollexclusive-flag/ >> >> PS, >> >> Original cases 0m24.953s vs 0m41.826s now probably is related with my >> pc >> setup. As I just now re-run test with original patch, got the same ~41 >> sec. >> >> So I am fine with this patch! >> > > Thanks, I shall add your Tested-by: > > One thing we're sorely missing is an epoll test suite, in > tools/testing/selftests. If anyone has anything which we can use to > kick things off, please hand it over ;) Not bad idea, probably we need a "tools/testing/selftests/eventpoll" folder under which we should have test cases for various epoll scenarios with common "run.sh". In spare time I can try to build a case for EXCLUSIVE flag (with queues & multiple processes :) ). Thanks, Madars