* [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first
@ 2024-02-16 20:31 Douglas Anderson
2024-02-16 21:21 ` Jessica Zhang
2024-02-19 9:11 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2024-02-16 20:31 UTC (permalink / raw
To: dri-devel
Cc: Stephen Boyd, Douglas Anderson, Abhinav Kumar, Daniel Vetter,
David Airlie, Dmitry Baryshkov, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Sam Ravnborg, Thomas Zimmermann,
linux-kernel
The panel on sc7180-trogdor-wormdingler and
sc7180-trogdor-quackingstick hasn't been coming up since commit
9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts
at modeset"). Let's add "prepare_prev_first" as has been done for many
other DSI panels.
Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
This of course gets into debates about getting a nicer solution that
doesn't involve adding "prepare_prev_first" to every DSI panel out
there, maybe building on Dmitry's work [1]. While it would be nice if
we could get there, getting this landed is easy to backport to stable
trees and gets the panel working again.
[1] https://lore.kernel.org/r/20231016165355.1327217-4-dmitry.baryshkov@linaro.org
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index c4c0f08e9202..bc08814954f9 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -1871,6 +1871,8 @@ static int boe_panel_add(struct boe_panel *boe)
gpiod_set_value(boe->enable_gpio, 0);
+ boe->base.prepare_prev_first = true;
+
drm_panel_init(&boe->base, dev, &boe_panel_funcs,
DRM_MODE_CONNECTOR_DSI);
err = of_drm_get_panel_orientation(dev->of_node, &boe->orientation);
--
2.44.0.rc0.258.g7320e95886-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first
2024-02-16 20:31 [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first Douglas Anderson
@ 2024-02-16 21:21 ` Jessica Zhang
2024-02-19 9:11 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Jessica Zhang @ 2024-02-16 21:21 UTC (permalink / raw
To: Douglas Anderson, dri-devel
Cc: Stephen Boyd, Abhinav Kumar, Daniel Vetter, David Airlie,
Dmitry Baryshkov, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Sam Ravnborg, Thomas Zimmermann, linux-kernel
On 2/16/2024 12:31 PM, Douglas Anderson wrote:
> The panel on sc7180-trogdor-wormdingler and
> sc7180-trogdor-quackingstick hasn't been coming up since commit
> 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts
> at modeset"). Let's add "prepare_prev_first" as has been done for many
> other DSI panels.
>
> Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Hi Doug,
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
> ---
> This of course gets into debates about getting a nicer solution that
> doesn't involve adding "prepare_prev_first" to every DSI panel out
> there, maybe building on Dmitry's work [1]. While it would be nice if
> we could get there, getting this landed is easy to backport to stable
> trees and gets the panel working again.
>
> [1] https://lore.kernel.org/r/20231016165355.1327217-4-dmitry.baryshkov@linaro.org
>
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index c4c0f08e9202..bc08814954f9 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -1871,6 +1871,8 @@ static int boe_panel_add(struct boe_panel *boe)
>
> gpiod_set_value(boe->enable_gpio, 0);
>
> + boe->base.prepare_prev_first = true;
> +
> drm_panel_init(&boe->base, dev, &boe_panel_funcs,
> DRM_MODE_CONNECTOR_DSI);
> err = of_drm_get_panel_orientation(dev->of_node, &boe->orientation);
> --
> 2.44.0.rc0.258.g7320e95886-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first
2024-02-16 20:31 [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first Douglas Anderson
2024-02-16 21:21 ` Jessica Zhang
@ 2024-02-19 9:11 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-02-19 9:11 UTC (permalink / raw
To: dri-devel, Douglas Anderson
Cc: Stephen Boyd, Abhinav Kumar, Daniel Vetter, David Airlie,
Dmitry Baryshkov, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Sam Ravnborg, Thomas Zimmermann, linux-kernel
Hi,
On Fri, 16 Feb 2024 12:31:12 -0800, Douglas Anderson wrote:
> The panel on sc7180-trogdor-wormdingler and
> sc7180-trogdor-quackingstick hasn't been coming up since commit
> 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts
> at modeset"). Let's add "prepare_prev_first" as has been done for many
> other DSI panels.
>
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=42a7a16bedc991190310a02dd202e29cfac52525
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-19 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-16 20:31 [PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first Douglas Anderson
2024-02-16 21:21 ` Jessica Zhang
2024-02-19 9:11 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).