From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Suman Ghosh <sumang@marvell.com>
Subject: RE: [PATCH net-next] octeontx2-pf: flower: check for unsupported control flags
Date: Tue, 23 Apr 2024 04:54:01 +0000 [thread overview]
Message-ID: <BY3PR18MB473745831DE04E6694F9EFD4C6112@BY3PR18MB4737.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240422152735.175693-1-ast@fiberby.net>
> -----Original Message-----
> From: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> Sent: Monday, April 22, 2024 8:58 PM
> To: netdev@vger.kernel.org
> Cc: Asbjørn Sloth Tønnesen <ast@fiberby.net>; linux-kernel@vger.kernel.org;
> David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; Suman
> Ghosh <sumang@marvell.com>
> Subject: [EXTERNAL] [PATCH net-next] octeontx2-pf: flower: check for
> unsupported control flags
>
> Use flow_rule_is_supp_control_flags() to reject filters with unsupported
> control flags.
>
> In case any unsupported control flags are masked,
> flow_rule_is_supp_control_flags() sets a NL extended error message, and we
> return -EOPNOTSUPP.
>
> Remove FLOW_DIS_FIRST_FRAG specific error message, and treat it as any
> other unsupported control flag.
>
> Only compile-tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> index 6d4ce2ece8d0..e63cc1eb6d89 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -700,10 +700,6 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic,
> struct otx2_tc_flow *node,
> u32 val;
>
> flow_rule_match_control(rule, &match);
> - if (match.mask->flags & FLOW_DIS_FIRST_FRAG) {
> - NL_SET_ERR_MSG_MOD(extack, "HW doesn't
> support frag first/later");
> - return -EOPNOTSUPP;
> - }
>
> if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
> val = match.key->flags & FLOW_DIS_IS_FRAGMENT;
> @@ -721,6 +717,10 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic,
> struct otx2_tc_flow *node,
> return -EOPNOTSUPP;
> }
> }
> +
> + if
> (!flow_rule_is_supp_control_flags(FLOW_DIS_IS_FRAGMENT,
> + match.mask->flags,
> extack))
> + return -EOPNOTSUPP;
> }
>
> if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
> --
> 2.43.0
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
next prev parent reply other threads:[~2024-04-23 4:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 15:27 [PATCH net-next] octeontx2-pf: flower: check for unsupported control flags Asbjørn Sloth Tønnesen
2024-04-22 23:41 ` Jacob Keller
2024-04-22 23:43 ` Jacob Keller
2024-04-23 4:54 ` Sunil Kovvuri Goutham [this message]
2024-04-25 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY3PR18MB473745831DE04E6694F9EFD4C6112@BY3PR18MB4737.namprd18.prod.outlook.com \
--to=sgoutham@marvell.com \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).