From: "Tan, Ley Foon" <ley.foon.tan@intel.com>
To: Chen Hui <clare.chenhui@huawei.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Cc: "rfi@lists.rocketboards.org" <rfi@lists.rocketboards.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()
Date: Fri, 9 Apr 2021 08:55:40 +0000 [thread overview]
Message-ID: <BY5PR11MB38933FD0DB01EE34D07ED151CC739@BY5PR11MB3893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210409075748.226141-1-clare.chenhui@huawei.com>
> -----Original Message-----
> From: Chen Hui <clare.chenhui@huawei.com>
> Sent: Friday, April 9, 2021 3:58 PM
> To: Tan, Ley Foon <ley.foon.tan@intel.com>; lorenzo.pieralisi@arm.com;
> robh@kernel.org; bhelgaas@google.com
> Cc: rfi@lists.rocketboards.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
> altera_msi_probe()
>
> There is a error message within devm_ioremap_resource already, so remove
> the dev_err call to avoid redundant error message.
>
> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
> ---
> drivers/pci/controller/pcie-altera-msi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-altera-msi.c
> b/drivers/pci/controller/pcie-altera-msi.c
> index 42691dd8ebef..98aa1dccc6e6 100644
> --- a/drivers/pci/controller/pcie-altera-msi.c
> +++ b/drivers/pci/controller/pcie-altera-msi.c
> @@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device
> *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "vector_slave");
> msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(msi->vector_base)) {
> - dev_err(&pdev->dev, "failed to map vector_slave
> memory\n");
> + if (IS_ERR(msi->vector_base))
> return PTR_ERR(msi->vector_base);
> - }
>
> msi->vector_phy = res->start;
>
> --
Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
next prev parent reply other threads:[~2021-04-09 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 7:57 [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe() Chen Hui
2021-04-09 8:55 ` Tan, Ley Foon [this message]
2021-04-14 16:46 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB38933FD0DB01EE34D07ED151CC739@BY5PR11MB3893.namprd11.prod.outlook.com \
--to=ley.foon.tan@intel.com \
--cc=bhelgaas@google.com \
--cc=clare.chenhui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rfi@lists.rocketboards.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).