From: Daeho Jeong <daeho43@gmail.com>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO
Date: Sat, 27 Apr 2024 12:50:48 -0700 [thread overview]
Message-ID: <CACOAw_xuX-J=J5zYwK5kVxPGZWPa+KXBxQA2i-taPwzS2ds-aQ@mail.gmail.com> (raw)
In-Reply-To: <a08a091b-78d1-4fb1-982c-c51d9dff8f06@kernel.org>
On Fri, Apr 26, 2024 at 6:49 PM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/4/26 22:14, Daeho Jeong wrote:
> > On Fri, Apr 26, 2024 at 3:35 AM Chao Yu <chao@kernel.org> wrote:
> >>
> >> Otherwise, it breaks pinfile's sematics.
> >>
> >> Cc: Daeho Jeong <daeho43@gmail.com>
> >> Signed-off-by: Chao Yu <chao@kernel.org>
> >> ---
> >> fs/f2fs/data.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> >> index bee1e45f76b8..e29000d83d52 100644
> >> --- a/fs/f2fs/data.c
> >> +++ b/fs/f2fs/data.c
> >> @@ -1596,7 +1596,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)
> >>
> >> /* use out-place-update for direct IO under LFS mode */
> >> if (map->m_may_create &&
> >> - (is_hole || (f2fs_lfs_mode(sbi) && flag == F2FS_GET_BLOCK_DIO))) {
> >> + (is_hole || (flag == F2FS_GET_BLOCK_DIO && (f2fs_lfs_mode(sbi) &&
> >> + (!f2fs_sb_has_blkzoned(sbi) || !f2fs_is_pinned_file(inode)))))) {
> >> if (unlikely(f2fs_cp_error(sbi))) {
> >> err = -EIO;
> >> goto sync_out;
> >> --
> >> 2.40.1
> >
> > So, we block overwrite io for the pinfile here.
>
> I guess you mean we blocked append write for pinfile, right?
>
> >
> > static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
> >
> > {
> > ...
> > if (f2fs_is_pinned_file(inode) &&
> > !f2fs_overwrite_io(inode, pos, count)) {
>
> If !f2fs_overwrite_io() is true, it means it may trigger append write on
> pinfile?
Yes, I missed it. Thanks~
>
> Thanks,
>
> > ret = -EIO;
> > goto out_unlock;
> > }
> >
> >
> >>
prev parent reply other threads:[~2024-04-27 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:35 [PATCH] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO Chao Yu
2024-04-26 11:30 ` [f2fs-dev] " Zhiguo Niu
2024-04-27 1:50 ` Chao Yu
2024-04-26 14:14 ` Daeho Jeong
2024-04-27 1:49 ` Chao Yu
2024-04-27 19:50 ` Daeho Jeong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACOAw_xuX-J=J5zYwK5kVxPGZWPa+KXBxQA2i-taPwzS2ds-aQ@mail.gmail.com' \
--to=daeho43@gmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).