From: Linus Walleij <linus.walleij@linaro.org>
To: Doug Berger <opendmb@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Phil Elwell <phil@raspberrypi.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] gpio: of: support gpio-ranges for multiple gpiochip devices
Date: Fri, 3 May 2024 10:25:08 +0200 [thread overview]
Message-ID: <CACRpkda4v6Nu8V3MVamDpfs4qnc89e8Vd8fSyaNsqJQ40GQqZg@mail.gmail.com> (raw)
In-Reply-To: <20240424185039.1707812-3-opendmb@gmail.com>
Hi Dough,
thanks for your patch!
I'm a bit confused here:
On Wed, Apr 24, 2024 at 8:51 PM Doug Berger <opendmb@gmail.com> wrote:
> + /* Ignore ranges outside of this GPIO chip */
> + if (pinspec.args[0] >= (chip->offset + chip->ngpio))
> + continue;
> + if (pinspec.args[0] + pinspec.args[2] <= chip->offset)
> + continue;
Here pinspec.args[0] and [2] comes directly from the device tree.
The documentation in Documentation/devicetree/bindings/gpio/gpio.txt
says:
> 2.2) Ordinary (numerical) GPIO ranges
> -------------------------------------
>
> It is useful to represent which GPIOs correspond to which pins on which pin
> controllers. The gpio-ranges property described below represents this with
> a discrete set of ranges mapping pins from the pin controller local number space
> to pins in the GPIO controller local number space.
>
> The format is: <[pin controller phandle], [GPIO controller offset],
> [pin controller offset], [number of pins]>;
>
> The GPIO controller offset pertains to the GPIO controller node containing the
> range definition.
So I do not understand how pinspec[0] and [2] can ever be compared
to something involving chip->offset which is a Linux-specific offset.
It rather looks like you are trying to accomodate the Linux numberspace
in the ranges, which it was explicitly designed to avoid.
I just don't get it.
So NACK until I understand what is going on here.
Yours,
Linus Walleij
next prev parent reply other threads:[~2024-05-03 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 18:50 [PATCH 0/3] gpio: brcmstb: add support for gpio-ranges Doug Berger
2024-04-24 18:50 ` [PATCH 1/3] dt-bindings: gpio: brcmstb: add gpio-ranges Doug Berger
2024-04-24 23:11 ` Florian Fainelli
2024-04-25 6:59 ` Krzysztof Kozlowski
2024-05-03 7:57 ` Linus Walleij
2024-04-24 18:50 ` [PATCH 2/3] gpio: of: support gpio-ranges for multiple gpiochip devices Doug Berger
2024-04-24 23:14 ` Florian Fainelli
2024-04-26 7:32 ` Bartosz Golaszewski
2024-05-03 8:25 ` Linus Walleij [this message]
2024-05-03 20:21 ` Doug Berger
2024-05-05 12:25 ` Bartosz Golaszewski
2024-05-06 7:03 ` Linus Walleij
2024-05-06 7:02 ` Linus Walleij
2024-04-24 18:50 ` [PATCH 3/3] gpio: brcmstb: add support for gpio-ranges Doug Berger
2024-04-24 23:12 ` Florian Fainelli
2024-04-26 7:33 ` [PATCH 0/3] " Bartosz Golaszewski
2024-05-03 8:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda4v6Nu8V3MVamDpfs4qnc89e8Vd8fSyaNsqJQ40GQqZg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).