From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9743C7EE37 for ; Thu, 8 Jun 2023 13:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236100AbjFHNjW (ORCPT ); Thu, 8 Jun 2023 09:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236164AbjFHNi4 (ORCPT ); Thu, 8 Jun 2023 09:38:56 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83F6726B3 for ; Thu, 8 Jun 2023 06:38:55 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-777a2ef8d45so19144139f.2 for ; Thu, 08 Jun 2023 06:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686231534; x=1688823534; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XO1CigyiND3L02YzTiuKf1ibThwImhtncqElbj41kYc=; b=mnHhy4uzqnlQiGkCkIdasUBEdOiJcb/6vH26Sw+GbrtHdDdEIS3hHONhkFrxIORY2m Ll1kWdqdxYs9gpF2pnw2lK0/wN7SBRS+zVN3lJzyE378w7ylgNFjHQC3feoiVh8gset5 FtK/0uQSGf93L3qLkCnQeWnkKn5jBFSWa7h+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686231534; x=1688823534; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XO1CigyiND3L02YzTiuKf1ibThwImhtncqElbj41kYc=; b=JPpfc01SNisMe6K+zqKMEqRcSXh+DzEGK1k9ln7y5q3fVJzRDwHlEqoCPvtnutXOBK dxzzjrIQpBv4NVHCRQjMa8Box3rTgBrW+5JGV5GXBXCx0NCqtzCSMn8Eq6FZnK3mTMID xdsdL9fJ9uuDXzKDBYfKiJ4gRTXqMUyRdZnTKBet/iQfHlMaA8LNnuA+EhZRviVSInsf DxqdnfSOEJBaBL3LFjMS99AgxX+6dsb2uh6FP6rzXMcGnBDESdYSdPo3HKj8g8aB0mH7 f3CtVz9TzVoxg+fvTBK+75QekRE0fGyrO7dtn1R1Jf03ffMF/bXc4nqmpzmSL37xfDB0 1M8Q== X-Gm-Message-State: AC+VfDxJuf6kGSp0mGTildunVmX+HbkL+s6kIiH7i3aEAg8uiTvs6f5V zLg2YHguprTpp+mo17I1/SoPot2HQnEQRIlgL7k= X-Google-Smtp-Source: ACHHUZ6jUwOnu/NQcID3ecVSxpwpIZkAXqQk4U0/wJqRS2wfuJ/EU9wY8IP8wWbnl29pfdNVVY294g== X-Received: by 2002:a6b:6102:0:b0:763:92eb:f81e with SMTP id v2-20020a6b6102000000b0076392ebf81emr8992566iob.8.1686231534041; Thu, 08 Jun 2023 06:38:54 -0700 (PDT) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com. [209.85.166.176]) by smtp.gmail.com with ESMTPSA id y10-20020a5ec80a000000b0076c70f8c4d1sm364864iol.45.2023.06.08.06.38.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 06:38:53 -0700 (PDT) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-33b7f217dd0so136675ab.0 for ; Thu, 08 Jun 2023 06:38:53 -0700 (PDT) X-Received: by 2002:a05:6e02:12cb:b0:33d:8444:c071 with SMTP id i11-20020a056e0212cb00b0033d8444c071mr221148ilm.5.1686231532849; Thu, 08 Jun 2023 06:38:52 -0700 (PDT) MIME-Version: 1.0 References: <20230608130147.2835818-1-yangcong5@huaqin.corp-partner.google.com> <20230608130147.2835818-3-yangcong5@huaqin.corp-partner.google.com> In-Reply-To: <20230608130147.2835818-3-yangcong5@huaqin.corp-partner.google.com> From: Doug Anderson Date: Thu, 8 Jun 2023 06:38:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] HID: i2c-hid: elan: Add ili9882t timing To: Cong Yang Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com, hsinyi@google.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jun 8, 2023 at 6:02=E2=80=AFAM Cong Yang wrote: > > +static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data =3D= { > + .post_power_delay_ms =3D 1, > + .post_gpio_reset_on_delay_ms =3D 200, > + .post_gpio_reset_off_delay_ms =3D 65, > .hid_descriptor_address =3D 0x0001, > + /* this touchscreen is tightly integrated with the panel and assu= mes > + * that the relevant power rails (other than the IO rail) have al= ready > + * been turned on by the panel driver because we're a panel follo= wer. > + */ I don't think the above is the right block comment style for this file. The first "/*" should be on a line on its own. > + .main_supply_name =3D "null", This should actually be NULL without the quotes. ...then you should change the code not to try to grab the regulator in that case.