From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21F7C4707E for ; Fri, 21 May 2021 20:58:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6646613EC for ; Fri, 21 May 2021 20:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbhEUU7a (ORCPT ); Fri, 21 May 2021 16:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhEUU72 (ORCPT ); Fri, 21 May 2021 16:59:28 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CB5C061574; Fri, 21 May 2021 13:58:05 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id v19-20020a0568301413b0290304f00e3d88so19233623otp.4; Fri, 21 May 2021 13:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ab85Wj/pv/eyNCl9jj3/qpptG4tumUbJBe7Uftmergk=; b=DdprPYDEm5sNMdFVAXYdEMFrMv/Kiefs/9C+4QjFLvB8QUnGZbIUG3pRVi1U/IPHac 49eUuSEqNHAgcpRgMKSnzzbhMjpsUgqMNscLpk4Bs9g5EOCfc6vMVciTzFeOi/tV0KRj vIsz9qHhNPT0nWQK0wsGkegXgR5jNtt/2dkWH1lGZO91/IDIb01+2nPAJJVvGrDhAOmV 10moBR3buVC126UWuf8DQ15RzgkJM0DVply5vvzDvBcPt5I1M6UHVSGb4G1PP/SycFCL aDolkPD45t5HKqOuCaUKlLDhWquxw3YTBspd2tSdcdZluA9pA5D7dha+HI3q2pJKgIgv 7crQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ab85Wj/pv/eyNCl9jj3/qpptG4tumUbJBe7Uftmergk=; b=Qm5IStfpIa1Xdwx74x3GN08qFaHmYhZ40PjoQ7SVeLcMxa8DvMXBX/DGiPUye3lDA0 QFoKHeJPJcE+KnkDdHrOArm4r3DeMuHcH03yyGI0/KeyjAGbQGptbml9ubWbW/15HW5g z0e1Y/xuAY6wandA8ytZs7YNUY8IIl79ynEWgDK7mqrmnDHfu/E/CicDX2R5LHOvksPc Snkj9yLBhTtRij/xh934iqB1pdQs6pakkU9D/PnTYfhQ3kbRIggFjZ/j5Qp6nFwg8pAB mBp7yNBlCbJ949T2EayLMp/jh7oHbWMDdmL6zeRjVOOGAlmRJW2Wg2EvzKTuA3RfbHqd XhwA== X-Gm-Message-State: AOAM530SSUneTotflky+iMxFXmrev55v9YNEDfHrjvCvoXvQJ5UcHYkK QFxc5reaMHA2rwpyilstW5sW9EJvjsqNVL6Hxy8= X-Google-Smtp-Source: ABdhPJx3V+DsXUMXDdny3yj3qLa/FEDVRdL1jKpJIxgqkQN/OddU4parCfOQx7J2uD/2WkJI/ItEpc7QspYOIvQE4Rw= X-Received: by 2002:a9d:6548:: with SMTP id q8mr10018862otl.311.1621630684620; Fri, 21 May 2021 13:58:04 -0700 (PDT) MIME-Version: 1.0 References: <1621590628-75988-1-git-send-email-jiapeng.chong@linux.alibaba.com> <09e40764-1d3a-0dfe-b278-5b5ce04670a9@gmail.com> In-Reply-To: <09e40764-1d3a-0dfe-b278-5b5ce04670a9@gmail.com> From: Alex Deucher Date: Fri, 21 May 2021 16:57:53 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Fix inconsistent indenting To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Jiapeng Chong , "Deucher, Alexander" , Dave Airlie , xinhui pan , LKML , amd-gfx list , Christian Koenig , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Daniel Vetter , Sumit Semwal , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Fri, May 21, 2021 at 9:35 AM Christian K=C3=B6nig wrote: > > Am 21.05.21 um 11:50 schrieb Jiapeng Chong: > > Eliminate the follow smatch warning: > > > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:449 > > sdma_v5_0_ring_emit_mem_sync() warn: inconsistent indenting. > > > > Reported-by: Abaci Robot > > Signed-off-by: Jiapeng Chong > > Reviewed-by: Christian K=C3=B6nig > > > --- > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/a= md/amdgpu/sdma_v5_0.c > > index 75d7310..c45e1b0 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c > > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c > > @@ -440,20 +440,19 @@ static void sdma_v5_0_ring_emit_ib(struct amdgpu_= ring *ring, > > */ > > static void sdma_v5_0_ring_emit_mem_sync(struct amdgpu_ring *ring) > > { > > - uint32_t gcr_cntl =3D > > - SDMA_GCR_GL2_INV | SDMA_GCR_GL2_WB | SDMA_GCR_GLM_INV= | > > - SDMA_GCR_GL1_INV | SDMA_GCR_GLV_INV | SDMA_GCR_GL= K_INV | > > - SDMA_GCR_GLI_INV(1); > > + uint32_t gcr_cntl =3D SDMA_GCR_GL2_INV | SDMA_GCR_GL2_WB | SDMA_G= CR_GLM_INV | > > + SDMA_GCR_GL1_INV | SDMA_GCR_GLV_INV | SDMA_GC= R_GLK_INV | > > + SDMA_GCR_GLI_INV(1); > > > > /* flush entire cache L0/L1/L2, this can be optimized by performa= nce requirement */ > > amdgpu_ring_write(ring, SDMA_PKT_HEADER_OP(SDMA_OP_GCR_REQ)); > > amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD1_BASE_VA_31_7(0)= ); > > amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD2_GCR_CONTROL_15_= 0(gcr_cntl) | > > - SDMA_PKT_GCR_REQ_PAYLOAD2_BASE_VA_47_32(0)); > > + SDMA_PKT_GCR_REQ_PAYLOAD2_BASE_VA_47_32(0)); > > amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD3_LIMIT_VA_31_7(0= ) | > > - SDMA_PKT_GCR_REQ_PAYLOAD3_GCR_CONTROL_18_16(gcr_c= ntl >> 16)); > > + SDMA_PKT_GCR_REQ_PAYLOAD3_GCR_CONTROL_18_16(gcr= _cntl >> 16)); > > amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD4_LIMIT_VA_47_32(= 0) | > > - SDMA_PKT_GCR_REQ_PAYLOAD4_VMID(0)); > > + SDMA_PKT_GCR_REQ_PAYLOAD4_VMID(0)); > > } > > > > /** > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx