From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org,
"Stanley Yang" <Stanley.Yang@amd.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
linux-media@vger.kernel.org
Subject: Re: [RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
Date: Fri, 9 Jun 2023 15:05:47 -0400 [thread overview]
Message-ID: <CADnq5_OVMwV80XbTpdRECa54iDLK8+SGz==KWpWTJN+hs1QAkA@mail.gmail.com> (raw)
In-Reply-To: <20230609081732.3842341-16-lee@kernel.org>
These have already been fixed up.
Thanks!
Alex
On Fri, Jun 9, 2023 at 4:18 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush'
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> index 3b03dda854fdc..8cd7abe74e6c4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> @@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
> amdgpu_ring_write(ring, ring->funcs->nop);
> }
>
> -/**
> +/*
> * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine
> *
> * @ring: amdgpu ring pointer
> @@ -936,7 +936,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)
> return r;
> }
>
> -/**
> +/*
> * sdma_v6_0_ring_test_ib - test an IB on the DMA engine
> *
> * @ring: amdgpu_ring structure holding ring information
> @@ -1118,7 +1118,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib,
> ib->ptr[ib->length_dw++] = count - 1; /* number of entries */
> }
>
> -/**
> +/*
> * sdma_v6_0_ring_pad_ib - pad the IB
> * @ib: indirect buffer to fill with padding
> * @ring: amdgpu ring pointer
> @@ -1167,7 +1167,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
> SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */
> }
>
> -/**
> +/*
> * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA
> *
> * @ring: amdgpu_ring pointer
> --
> 2.41.0.162.gfafddb0af9-goog
>
prev parent reply other threads:[~2023-06-09 19:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:17 [RESEND 00/15] Rid W=1 warnings from GPU Lee Jones
2023-06-09 8:17 ` [RESEND 01/15] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Lee Jones
2023-06-09 8:17 ` [RESEND 02/15] drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train() -> zynqmp_dp_train() Lee Jones
2023-06-09 8:17 ` [RESEND 03/15] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting Lee Jones
2023-06-09 8:17 ` [RESEND 04/15] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header Lee Jones
2023-06-09 8:51 ` AngeloGioacchino Del Regno
2023-06-09 8:17 ` [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: " Lee Jones
2023-06-09 8:51 ` AngeloGioacchino Del Regno
2023-06-09 14:31 ` Matthias Brugger
2023-06-12 11:23 ` Lee Jones
2023-06-09 8:17 ` [RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Lee Jones
2023-06-09 12:08 ` Karol Herbst
2023-06-09 8:17 ` [RESEND 07/15] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses Lee Jones
2023-06-09 12:07 ` Karol Herbst
2023-06-09 8:17 ` [RESEND 08/15] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses Lee Jones
2023-06-09 12:08 ` Karol Herbst
2023-06-09 8:17 ` [RESEND 09/15] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse Lee Jones
2023-06-09 12:09 ` Karol Herbst
2023-06-09 8:17 ` [RESEND 10/15] drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block() Lee Jones
2023-06-09 12:09 ` Karol Herbst
2023-06-09 8:17 ` [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef Lee Jones
2023-06-09 14:54 ` Harry Wentland
2023-06-09 15:07 ` Hamza Mahfooz
2023-06-09 8:17 ` [RESEND 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses Lee Jones
2023-06-09 12:09 ` Karol Herbst
2023-06-11 6:59 ` [RESEND,12/15] " Sui Jingfeng
2023-06-09 8:17 ` [RESEND 13/15] drm/nouveau/nvkm/engine/gr/tu102: Completely remove unused function ‘tu102_gr_load’ Lee Jones
2023-06-09 8:17 ` [RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-06-09 19:03 ` Alex Deucher
2023-06-09 8:17 ` [RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-06-09 19:05 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_OVMwV80XbTpdRECa54iDLK8+SGz==KWpWTJN+hs1QAkA@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Stanley.Yang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).