From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69765C433ED for ; Thu, 20 May 2021 19:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D39B608FE for ; Thu, 20 May 2021 19:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238594AbhETTSk (ORCPT ); Thu, 20 May 2021 15:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238674AbhETTS2 (ORCPT ); Thu, 20 May 2021 15:18:28 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 907D9C06138A for ; Thu, 20 May 2021 12:17:05 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id b25so17489198oic.0 for ; Thu, 20 May 2021 12:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Du5kz67a/iQ6a/NjTr+Df2buicUv7+vIDaRHiI4Tcpc=; b=WXsOHWQnfuFGEy/0apmg3pys11mvrLhSyFPuVqhVuh7E+rjuByzK56J+my50Jk/pEj OReru0IMuPnzI1aZb2My0T191LPM4bid2i8FL78Wpz1/eYdYfVzZ1qExUnGDLikO1Pgi KMvALHv7Mi8P1CJRvSqJRX+hQbk5EFGz4dmf3gJlQsNr0vXnpR+/QFo8Bc/ql3YUrTML EehvuwxUgeYpKr4xU9Su+R/6A/xMgF9OSInuCWd+oKiJH2MUyYQ32MGjFw0UIO1z+tgH nUZFaYMI9sJ3gK1sHEuGCiRiX5QIDGoWZmsGOrKzberNzmkexJLmikoP0bGWNENqF8mK Gb6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Du5kz67a/iQ6a/NjTr+Df2buicUv7+vIDaRHiI4Tcpc=; b=UjnjFayjAxqILQLaA/TER9zuc1NdMmDD22IkYb+dNOV67WA72v7qGAc15IBnNa4D5R ZSnmK3WP741kaKLdNOkF/NyUCMCHXgLHFg7Qcwy9O/rBdjKYnj6auHibdTPmQFdW15ur +fpJVPqh77QrVQnsafsUT1vcZS7nunUrsiULVrU0uum/Hch5MVMH0xOwZd9t3L54H2SU 6Uxgz1MkYprHLqlFGBEvRDiqhyqoNDKWP+KX7kJnWy0Gc/4bv0hHOWWNM4ojjcfyt/6V vCsvpqfccseZe/mmBvySeXqgU4Pv6zvAUgSq9I0uQbcg5UTzg3LYnfJVKzjwsrVaKR9d O7Ew== X-Gm-Message-State: AOAM532rvIc839ETn5bYGHde1kYDduETugbS+4ZD7xhMm9t8RK8T8kh1 hd0Tc2LQCQTE77XyihNJ3GxqX3RcgIXeE37R7hE= X-Google-Smtp-Source: ABdhPJxdH46PVylAq5rTQ6Izow1yHwsSulVm3OW7d6kIYtHslqzWnlyagjo4KPAVAi6bcRGTXb2IYNf9hlUcE89yz7M= X-Received: by 2002:a05:6808:1592:: with SMTP id t18mr2477039oiw.123.1621538225046; Thu, 20 May 2021 12:17:05 -0700 (PDT) MIME-Version: 1.0 References: <20210520120248.3464013-1-lee.jones@linaro.org> <20210520120248.3464013-21-lee.jones@linaro.org> In-Reply-To: From: Alex Deucher Date: Thu, 20 May 2021 15:16:53 -0400 Message-ID: Subject: Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Lee Jones , David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Daniel Vetter , Alex Deucher Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Thu, May 20, 2021 at 8:05 AM Christian K=C3=B6nig wrote: > > Am 20.05.21 um 14:02 schrieb Lee Jones: > > Fixes the following W=3D1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype f= or radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead > > drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype = for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_direct= ory() instead > > > > Cc: Alex Deucher > > Cc: "Christian K=C3=B6nig" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: amd-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > Reviewed-by: Christian K=C3=B6nig > > > --- > > drivers/gpu/drm/radeon/radeon_vm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeo= n/radeon_vm.c > > index 2dc9c9f98049b..36a38adaaea96 100644 > > --- a/drivers/gpu/drm/radeon/radeon_vm.c > > +++ b/drivers/gpu/drm/radeon/radeon_vm.c > > @@ -51,7 +51,7 @@ > > */ > > > > /** > > - * radeon_vm_num_pde - return the number of page directory entries > > + * radeon_vm_num_pdes - return the number of page directory entries > > * > > * @rdev: radeon_device pointer > > * > > @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags= ) > > } > > > > /** > > - * radeon_vm_update_pdes - make sure that page directory is valid > > + * radeon_vm_update_page_directory - make sure that page directory is = valid > > * > > * @rdev: radeon_device pointer > > * @vm: requested vm > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx