From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965732AbcBCShT (ORCPT ); Wed, 3 Feb 2016 13:37:19 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34319 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965663AbcBCShP (ORCPT ); Wed, 3 Feb 2016 13:37:15 -0500 MIME-Version: 1.0 In-Reply-To: <56B24642.8090105@codeaurora.org> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> Date: Thu, 4 Feb 2016 02:37:14 +0800 Message-ID: Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support From: Fu Wei To: Timur Tabi Cc: Rob Herring , =?UTF-8?Q?Pawe=C5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Guenter Roeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun Guo , Jon Masters , Arnd Bergmann , Leo Duran , Sudeep Holla Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 February 2016 at 02:26, Timur Tabi wrote: > Fu Wei wrote: >> >> Actually, >> the SBSA watchdog driver should support only half-timeout for panic >> the user cannot configure the length of "panic time", He can only >> enable it, and it is automatically set to 1/2 timeout. >> >> we don't need pre-timeout here. >> >> Hope I understand you correctly:-) sorry for your confusion >> >>> > >>> >So when pre-timeout occurs, the interrupt handler calls panic() or >>> > whatever >>> >it's supposed to do. >> >> Actually, >> So when 1/2 timeout occurs, the interrupt handler calls panic() or >> whatever it's supposed to do. >> > > I understand all that. What I'm saying is that, in the future, when > pre-timeout support is added to the watchdog layer, I think it makes sense > to modify this driver to use pre-timeout support. As you know I have made the pre-timeout support patch, If people like it, i am happy to go on upstream it separately. If we want to use pre-timeout here, user only can use get_pretimeout and disable panic by setting pretimeout to 0 but user can not really set pretimeout, because "pre-timeout == timeout / 2 (always)". if user want to change pretimeout, he/she has to set_time instead. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021