From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965476AbcBCSSn (ORCPT ); Wed, 3 Feb 2016 13:18:43 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:35390 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965198AbcBCSSj (ORCPT ); Wed, 3 Feb 2016 13:18:39 -0500 MIME-Version: 1.0 In-Reply-To: <56B2423B.1020109@codeaurora.org> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> Date: Thu, 4 Feb 2016 02:18:38 +0800 Message-ID: Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support From: Fu Wei To: Timur Tabi Cc: Rob Herring , =?UTF-8?Q?Pawe=C5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Guenter Roeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun Guo , Jon Masters , Arnd Bergmann , Leo Duran , sudeep.holla@arm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 February 2016 at 02:08, Timur Tabi wrote: > Fu Wei wrote: >> >> Actually I am taking your suggestion to avoid touching WCV in >> interrupt routine. >> So even we have pre-timeout support , it is useless for this >> panic-on-half-timeout feature, >> because pre-timeout == timeout / 2 (always). >> >> So maybe I misunderstand your suggestion, >> could you let me know : why we want pre-timeout here? > > > Maybe I'm confused. > > For pre-timeout, I think the SBSA watchdog driver should support only > half-timeout. That is, the user cannot configure the length of the > pre-timeout with this driver. He can only enable it, and it is > automatically set to 1/2 timeout. Actually, the SBSA watchdog driver should support only half-timeout for panic the user cannot configure the length of "panic time", He can only enable it, and it is automatically set to 1/2 timeout. we don't need pre-timeout here. Hope I understand you correctly :-) sorry for your confusion > > So when pre-timeout occurs, the interrupt handler calls panic() or whatever > it's supposed to do. Actually, So when 1/2 timeout occurs, the interrupt handler calls panic() or whatever it's supposed to do. > > So "pre-timeout == timeout / 2 (always)" is exactly what we want. our patchset is doing this way. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021