From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Hyeonki Hong <hhk7734@gmail.com>
Subject: Re: [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+
Date: Mon, 5 Apr 2021 22:56:34 +0200 [thread overview]
Message-ID: <CAFBinCAJMvdus+bUjDpJxrATfifG7BstdKi=x_yUEYH0RqhJUQ@mail.gmail.com> (raw)
In-Reply-To: <20210329161256.31171-3-christianshewitt@gmail.com>
On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> From: Hyeonki Hong <hhk7734@gmail.com>
>
> Add the meson saradc node to the ODROID N2/N2+ common dtsi.
in general I am fine with this as some SAR ADC channels seem to be on
the pin headers...
[...]
> +&saradc {
> + status = "okay";
> +};
...but a vref-supply should be provided to get meaningful numbers
next prev parent reply other threads:[~2021-04-05 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 16:12 [PATCH 0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes Christian Hewitt
2021-03-29 16:12 ` [PATCH 1/3] arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node Christian Hewitt
2021-03-30 15:22 ` Neil Armstrong
2021-04-05 20:54 ` Martin Blumenstingl
2021-03-29 16:12 ` [PATCH 2/3] arm64: dts: meson: add saradc node to ODROID N2/N2+ Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-04-05 20:56 ` Martin Blumenstingl [this message]
2021-03-29 16:12 ` [PATCH 3/3] arm64: dts: meson: add GPIO line names " Christian Hewitt
2021-03-30 15:23 ` Neil Armstrong
2021-03-31 21:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCAJMvdus+bUjDpJxrATfifG7BstdKi=x_yUEYH0RqhJUQ@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hhk7734@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).