From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EA2C433ED for ; Thu, 20 May 2021 12:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24AC56108C for ; Thu, 20 May 2021 12:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237444AbhETMIj (ORCPT ); Thu, 20 May 2021 08:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237423AbhETMIU (ORCPT ); Thu, 20 May 2021 08:08:20 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC088C06EA71 for ; Thu, 20 May 2021 03:39:44 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id z4so6590486plg.8 for ; Thu, 20 May 2021 03:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m/RdGTpHpIlnNqukYMSfOi40wGs3gJ2bxRFA/p/HWmc=; b=Vhj8ZxDnRnFsKkjgvE0jTxFiP9E6eGyLcgWFUbcEE6BPCOaYrfiee/sSxQ3bZ3EmIA 8qUPu2mopXJqA5KvDOG7fLjhRNErG+GGUFexzHbLH4YKa69rcXjN0GBvGE1rsIY05p2e VROBlatX93nO4HEMcczfdE1W935uS1GxpIkkQGV0VWsWo71UQYT7Tq39t5h0jiz88DUu q13f+kH8jZmY1bdai6bxM2NpJ4rOaf/sGrOVZ3+cn8Z5zd9zHRc5AIobTBTe0Q7cq/zo GkW4aBUXx17jLCVVrC8mDrHyqSPGRU0oaLUS2156S3ymDUAjA0k6rDXw736AH2PngNEw ENdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m/RdGTpHpIlnNqukYMSfOi40wGs3gJ2bxRFA/p/HWmc=; b=t+cWdSUBdKu3LDliX1jF06bpiErwyWltGAdpybjRdRIRkTAMP43U3gjvPxtjZTAkRg JJ6B7UW7eSbSlouP4Fg6IIMjBhIwH/cUO1v/Aof7V+FSv4UQS6SKKtObjjAgJP6zDTeT kO4q7ps5n4HA7Csghw3TcNZhp/UtLCeWH6iLlgvOfi2aq690/zghfo8TQLaUBIMyxuRl QgMeslZciobVrDmDWA8A4hIHsjZTReo+q/lBudnVxlX5R5Hw13pb5gWSI/c8OhQn6nqO HRciJxUZ1vTDUQkx74eBNSazlbuewfEclPIQoQDw2txpZts1p42KqYZaXFEKp+wpQYag aBpg== X-Gm-Message-State: AOAM530iszDSJbj5DdAAhAYXxW6Dbe3uD0ggZ4BVlJufUHyQUYcGNOll 6maX4ZwOavfkMIieTLk7P1wDFHJxrlTKVzw91XoLUg== X-Google-Smtp-Source: ABdhPJzf2fR6d+CPHdEr95MzZvm9RJFlJaLVIyK+Nk/R1dCYvI8lZdQuPG7bvcKxY0sCx8N2rOrD6gLETNVjiPOY5J0= X-Received: by 2002:a17:902:b70f:b029:f4:5445:cd9f with SMTP id d15-20020a170902b70fb02900f45445cd9fmr5262680pls.32.1621507184286; Thu, 20 May 2021 03:39:44 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-6-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-6-jonathan@marek.ca> From: Robert Foss Date: Thu, 20 May 2021 12:39:33 +0200 Message-ID: Subject: Re: [PATCH 05/17] media: camss: csid-170: don't enable unused irqs To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > csid_isr() only checks for the reset irq, so enabling any other irqs > doesn't make sense. The "RDI irq" comment is also wrong, the register > should be CSID_CSI2_RDIN_IRQ_MASK. Without this fix there may be an > excessive amount of irqs. > > Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") > Signed-off-by: Jonathan Marek > --- > drivers/media/platform/qcom/camss/camss-csid-170.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c > index a81cc94c075f..2bc695819919 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-170.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c > @@ -443,12 +443,6 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) > val |= 1 << CSI2_RX_CFG1_MISR_EN; > writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); // csi2_vc_mode_shift_val ? > > - /* error irqs start at BIT(11) */ > - writel_relaxed(~0u, csid->base + CSID_CSI2_RX_IRQ_MASK); > - > - /* RDI irq */ > - writel_relaxed(~0u, csid->base + CSID_TOP_IRQ_MASK); > - > val = 1 << RDI_CTRL_HALT_CMD; > writel_relaxed(val, csid->base + CSID_RDI_CTRL(0)); > } Reviewed-by: Robert Foss