From: grygorii tertychnyi <grembeter@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>,
bsp-development.geo@leica-geosystems.com,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
Peter Korsgaard <peter@korsgaard.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled
Date: Mon, 20 May 2024 17:01:34 +0200 [thread overview]
Message-ID: <CAGFuAuwot_7+R=J4NC=0Z_48YZ-RTJjRUoQnSjZUvpt=AWF39Q@mail.gmail.com> (raw)
In-Reply-To: <a42d75ad-8065-49f0-906a-c8ae3761457c@lunn.ch>
On Mon, May 20, 2024 at 3:41 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote:
> > On Sun, May 19, 2024 at 7:25 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > >
> > > …
> > > > Sometimes it causes failure for the very first message transfer, …
> > >
> > > Does such an information indicate the need for the tag “Fixes”?
> >
> > I'm not sure: the original initialization order was introduced by the
> > very first commit
> > 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller").
>
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
> It fixes a problem like an oops, a hang, data corruption, a real
> security issue, a hardware quirk, a build error (but not for things
> marked CONFIG_BROKEN), or some “oh, that’s not good” issue.
>
> Your description of the very first message transfer failing sounds
> like a data corruption? Using the commit which adds the driver is also
> fine, some bugs have been there all the time.
Thanks! Yes, it is a data corruption.
> Remember to add a
>
> Cc: stable@vger.kernel.org
I will send v2.
Regards,
Grygorii
prev parent reply other threads:[~2024-05-20 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 19:10 [PATCH] i2c: ocores: set IACK bit after core is enabled Grygorii Tertychnyi
2024-05-18 18:46 ` Peter Korsgaard
2024-05-19 5:25 ` Markus Elfring
2024-05-20 13:30 ` grygorii tertychnyi
2024-05-20 13:41 ` Andrew Lunn
2024-05-20 15:01 ` grygorii tertychnyi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGFuAuwot_7+R=J4NC=0Z_48YZ-RTJjRUoQnSjZUvpt=AWF39Q@mail.gmail.com' \
--to=grembeter@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=andrew@lunn.ch \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=grygorii.tertychnyi@leica-geosystems.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).